Commit fa48f1d
committed
fix(intake): regenerate API contracts and tighten the metrics endpoint
Addresses review findings on #1374.
P1 — the generated contracts were missing the new surface, failing CI's
Lint all. Regenerated OpenAPI, the Python SDK via Stainless, the vendored
CLI, and the web SDK. The traces resource now exposes `get_metrics`, and
`Trace` carries agent_id / agent_name / agent_version.
Stainless placed the new endpoint as a top-level `trace_metrics`
standalone API with a `reviewme_list` method. Per the resolve-reviewme
guidance, a single-method resource folds into its parent, so it lives on
the existing intake `traces` resource as `get_metrics`; the path and
schemas are untouched.
P3 — the metrics endpoint accepted page, page_size and sort through the
shared list validator and silently ignored them, implying a paginated
response where every bucket in the range is returned. It now validates
against its own parameter set, so `?page=999` is a 400 rather than a
misleading 200.
P3 — the span rollup CTE filtered only on trace_id, so a trace_id shared
across ingest formats pulled in unrelated spans before the join discarded
them. Restrict by (source_format, trace_id) as the page-refs variant and
the join already do. trace_id is kept in the predicate to drive the bloom
filter. Verified the figures are unchanged against live ClickHouse.
Signed-off-by: mschwab <mschwab@nvidia.com>1 parent 3930a5d commit fa48f1d
62 files changed
Lines changed: 1736 additions & 198 deletions
File tree
- docs/cli
- openapi
- ga
- individual
- packages/nemo_platform_ext/src/nemo_platform_ext/cli/commands/api/intake
- ingest
- sdk
- python/nemo-platform
- .devcontainer
- .github/workflows
- .nmpcontext
- bin
- scripts
- utils
- src/nemo_platform
- cli/commands/api/intake
- ingest
- resources
- access_keys
- adapters
- auth
- entities
- evaluations
- experiments
- files
- guardrail
- iam
- inference
- intake
- ingest
- jobs
- models
- projects
- secrets
- workspaces
- types/intake
- ingest
- tests
- api_resources/intake
- ingest
- services/intake
- src/nmp/intake
- repository/clickhouse
- spans/api
- tests
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6811 | 6811 | | |
6812 | 6812 | | |
6813 | 6813 | | |
6814 | | - | |
| 6814 | + | |
6815 | 6815 | | |
6816 | 6816 | | |
6817 | 6817 | | |
| |||
7103 | 7103 | | |
7104 | 7104 | | |
7105 | 7105 | | |
| 7106 | + | |
7106 | 7107 | | |
7107 | 7108 | | |
7108 | 7109 | | |
| 7110 | + | |
| 7111 | + | |
| 7112 | + | |
| 7113 | + | |
| 7114 | + | |
| 7115 | + | |
| 7116 | + | |
| 7117 | + | |
| 7118 | + | |
| 7119 | + | |
| 7120 | + | |
| 7121 | + | |
| 7122 | + | |
| 7123 | + | |
| 7124 | + | |
| 7125 | + | |
| 7126 | + | |
| 7127 | + | |
| 7128 | + | |
| 7129 | + | |
| 7130 | + | |
| 7131 | + | |
| 7132 | + | |
| 7133 | + | |
| 7134 | + | |
| 7135 | + | |
| 7136 | + | |
| 7137 | + | |
| 7138 | + | |
| 7139 | + | |
| 7140 | + | |
| 7141 | + | |
| 7142 | + | |
| 7143 | + | |
| 7144 | + | |
| 7145 | + | |
| 7146 | + | |
| 7147 | + | |
| 7148 | + | |
7109 | 7149 | | |
7110 | 7150 | | |
7111 | 7151 | | |
| |||
7133 | 7173 | | |
7134 | 7174 | | |
7135 | 7175 | | |
| 7176 | + | |
| 7177 | + | |
7136 | 7178 | | |
7137 | 7179 | | |
7138 | 7180 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments