fix: gop cache LRU bug#30
Closed
xupinjie wants to merge 1 commit into
Closed
Conversation
Collaborator
|
/build |
eed4f3f to
bdcb696
Compare
Collaborator
Author
|
/build |
RmSchaffert
reviewed
Jun 11, 2026
RmSchaffert
left a comment
Collaborator
There was a problem hiding this comment.
Thank you! Please see the in-line comment in the code and also add a sign-off to the commit.
| 2. Only demuxes for cache misses | ||
| 3. Updates cache with new data | ||
| 4. Returns results from cache (preserving original order) | ||
| When useGOPCache=True: |
Collaborator
There was a problem hiding this comment.
This is not recognized as an enumeration of bullet points (and also leads to an error in the documentation generation due to the indentation in point 1). Please fix. You can e.g. add an indentation to make it an enumeration:
When useGOPCache=True:
1. GOP replacement is per video: the cache keeps only one GOP per video
(keyed by file path).
2. Videos are evicted by LRU when the cache exceeds ``maxfiles`` entries.
3. On a cache miss, the GOP is demuxed from the video file.
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Set the maximum number of slots for the GOP cache.
Type of Change
Please select (at least one):
Testing
Checklist for testing:
scripts/run_tests.shOptionally, add a brief description.
Documentation, Examples, Tutorials, Demos
Checklist for documentation:
Optionally, add a brief description.
Code Quality
Checklist for dependencies:
pyproject.tomlif/as neededOptionally, add a brief description.
Related Issues / Context
If applicable, link related issues, discussions etc.
DCO / Sign-Off
Please refer to the section on Signing Your Work & Developer Certificate of Origin (DCO)
in the Contribution Guide before submitting your contribution.
References
For additional details, please refer to the Contribution Guide.
The following guides are available (referenced in the Contribution Guide for further details):
docs/guides/CONTRIBUTION_GUIDE.mddocs/guides/DEVELOPMENT_GUIDE.mddocs/guides/DOCUMENTATION_SETUP_GUIDE.mddocs/guides/FORMATTING_GUIDE.mdPlease also refer to the summary checklist in the Contribution Guide,
which is a guideline for what to consider when submitting your contribution and covers the same topics as the checklists above.