Skip to content

fix: gop cache LRU bug#30

Closed
xupinjie wants to merge 1 commit into
NVIDIA:mainfrom
xupinjie:pinjie/fix_gop_cache_lru_bug
Closed

fix: gop cache LRU bug#30
xupinjie wants to merge 1 commit into
NVIDIA:mainfrom
xupinjie:pinjie/fix_gop_cache_lru_bug

Conversation

@xupinjie

Copy link
Copy Markdown
Collaborator

Description

Set the maximum number of slots for the GOP cache.

Type of Change

Please select (at least one):

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation / examples / tutorials / demos
  • Supporting functionality change (fix or feature in documentation generation, helper scripts, ...)
  • Refactoring / internal change
  • Other (please describe):

Testing

Checklist for testing:

  • Tests added or updated if/as needed
  • Repository test runner executed: scripts/run_tests.sh

Optionally, add a brief description.

Documentation, Examples, Tutorials, Demos

Checklist for documentation:

  • User-facing documentation updated if/as needed (including API docs)
  • Examples / tutorials / demos updated or added (if relevant)
  • Limitations and constraints documented (if relevant)
  • Performance documented (if relevant)
  • Documentation building successful & checks outlined in the Documentation Checks section of the Contribution Guide are performed

Optionally, add a brief description.

Code Quality

Checklist for dependencies:

  • Dependencies updated in the relevant pyproject.toml if/as needed
  • Code formatted according to the Code Formatting Guide

Optionally, add a brief description.

Related Issues / Context

If applicable, link related issues, discussions etc.


DCO / Sign-Off

Please refer to the section on Signing Your Work & Developer Certificate of Origin (DCO)
in the Contribution Guide before submitting your contribution.

References

For additional details, please refer to the Contribution Guide.
The following guides are available (referenced in the Contribution Guide for further details):

Please also refer to the summary checklist in the Contribution Guide,
which is a guideline for what to consider when submitting your contribution and covers the same topics as the checklists above.

@xupinjie xupinjie requested a review from RmSchaffert June 10, 2026 09:38
@RmSchaffert

Copy link
Copy Markdown
Collaborator

/build

@xupinjie xupinjie force-pushed the pinjie/fix_gop_cache_lru_bug branch from eed4f3f to bdcb696 Compare June 11, 2026 02:26
@xupinjie

Copy link
Copy Markdown
Collaborator Author

/build

@RmSchaffert RmSchaffert left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Please see the in-line comment in the code and also add a sign-off to the commit.

2. Only demuxes for cache misses
3. Updates cache with new data
4. Returns results from cache (preserving original order)
When useGOPCache=True:

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not recognized as an enumeration of bullet points (and also leads to an error in the documentation generation due to the indentation in point 1). Please fix. You can e.g. add an indentation to make it an enumeration:

When useGOPCache=True:
    1. GOP replacement is per video: the cache keeps only one GOP per video
       (keyed by file path).
    2. Videos are evicted by LRU when the cache exceeds ``maxfiles`` entries.
    3. On a cache miss, the GOP is demuxed from the video file.

@xupinjie xupinjie mentioned this pull request Jun 11, 2026
16 tasks
@xupinjie xupinjie closed this Jun 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants