Remove unused async decoder preallocations#32
Closed
KazukiKomon wants to merge 1 commit into
Closed
Conversation
Signed-off-by: hongyizhang <hongyizhang02@deeproute.ai>
Contributor
Author
|
Closing this draft because it only covered a cleanup follow-up, not the intended internal MR diff. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove unused
cuMemAllocAsyncpreallocations fromNvDecoder::HandleVideoSequenceandNvDecoder::ReconfigureDecoder.These local
pFrame[8]allocations are not stored inm_vpFrame, so they are not managed by the decoder frame lifecycle and cannot be released by the destructor. Output frame buffers are already allocated lazily inHandlePictureDisplayand tracked bym_vpFrame.This is intended as a small cleanup/risk reduction before enabling
bEnableAsyncAllocationsin GOP decode paths.Verification
git diff --check