Skip to content

Checkpoint conversion between GPT_model and Hybrid_model#4482

Open
guihong-nv wants to merge 8 commits intoNVIDIA:mainfrom
guihong-nv:convert_ckpt
Open

Checkpoint conversion between GPT_model and Hybrid_model#4482
guihong-nv wants to merge 8 commits intoNVIDIA:mainfrom
guihong-nv:convert_ckpt

Conversation

@guihong-nv
Copy link
Copy Markdown
Contributor

@guihong-nv guihong-nv commented Apr 27, 2026

What does this PR do ?

  • Checkpoint conversion between GPT_model and Hybrid_model
  • For GPT_model, we do not support the legacy models

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

…d_model

Signed-off-by: guihong-nv <guihongl@nvidia.com>
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Apr 27, 2026

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

Signed-off-by: guihong-nv <guihongl@nvidia.com>
Signed-off-by: guihong-nv <guihongl@nvidia.com>
Signed-off-by: guihong-nv <guihongl@nvidia.com>
Signed-off-by: guihong-nv <guihongl@nvidia.com>
Signed-off-by: guihong-nv <guihongl@nvidia.com>
Signed-off-by: guihong-nv <guihongl@nvidia.com>
Signed-off-by: guihong-nv <guihongl@nvidia.com>
@guihong-nv
Copy link
Copy Markdown
Contributor Author

/ok to test 2f9c46d

@guihong-nv guihong-nv marked this pull request as ready for review April 30, 2026 15:55
@svcnvidia-nemo-ci svcnvidia-nemo-ci requested a review from a team April 30, 2026 15:55
@ericharper ericharper added this pull request to the merge queue Apr 30, 2026
@svcnvidia-nemo-ci
Copy link
Copy Markdown

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/25177806849

@Phlip79 Phlip79 removed this pull request from the merge queue due to a manual request Apr 30, 2026
Copy link
Copy Markdown
Member

@Phlip79 Phlip79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please update references from MambaModel to HybridModel (and all other references to Mamba)? Mamba should only be a reference to the layer (i.e. SSM).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants