Commit 15557e5
committed
fix(docker): propagate OPENSHELL_IMAGE_TAG to cross-compile Dockerfiles
Three Dockerfiles that cross-compile CLI binaries via Docker were missing
ARG OPENSHELL_IMAGE_TAG declarations. The CI workflows and build scripts
already pass this as a --build-arg, but without the ARG declaration Docker
silently drops it. This caused Rust's option_env!("OPENSHELL_IMAGE_TAG")
to resolve to None at compile time, falling back to "dev" for
DEFAULT_IMAGE_TAG in stable release binaries.
Affected artifacts:
- macOS CLI binary (Dockerfile.cli-macos)
- Linux Python wheels (Dockerfile.python-wheels)
- macOS Python wheels (Dockerfile.python-wheels-macos)
The Linux CLI binary was not affected because it builds directly in the
CI container where OPENSHELL_IMAGE_TAG is set as a real env var.1 parent ef196db commit 15557e5
File tree
3 files changed
+6
-3
lines changed- deploy/docker
3 files changed
+6
-3
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
103 | 103 | | |
104 | 104 | | |
105 | 105 | | |
106 | | - | |
| 106 | + | |
107 | 107 | | |
108 | 108 | | |
| 109 | + | |
109 | 110 | | |
110 | 111 | | |
111 | 112 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
84 | 84 | | |
85 | 85 | | |
86 | 86 | | |
87 | | - | |
| 87 | + | |
88 | 88 | | |
89 | 89 | | |
| 90 | + | |
90 | 91 | | |
91 | 92 | | |
92 | 93 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
91 | 91 | | |
92 | 92 | | |
93 | 93 | | |
94 | | - | |
| 94 | + | |
95 | 95 | | |
96 | 96 | | |
| 97 | + | |
97 | 98 | | |
98 | 99 | | |
99 | 100 | | |
| |||
0 commit comments