Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CUB/docs] Add missing closing braces to BlockReduce kernel examples in CUB docs. #3916

Merged
merged 1 commit into from
Feb 23, 2025
Merged

[CUB/docs] Add missing closing braces to BlockReduce kernel examples in CUB docs. #3916

merged 1 commit into from
Feb 23, 2025

Conversation

brycelelbach
Copy link
Collaborator

All of the CUB BlockReduce kernel examples are missing a closing brace. This is a documentation only change.

@brycelelbach brycelelbach requested a review from a team as a code owner February 23, 2025 15:55
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Feb 23, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@brycelelbach
Copy link
Collaborator Author

@miscco @bernhardmgruber

@elstehle
Copy link
Collaborator

/ok to test

@elstehle elstehle enabled auto-merge (squash) February 23, 2025 16:07
@github-actions GitHub Actions
Copy link
Contributor

🟩 CI finished in 1h 21m: Pass: 100%/93 | Total: 1d 00h | Avg: 15m 55s | Max: 1h 18m | Hits: 92%/133929

  • 🟩 cub: Pass: 100%/45 | Total: 14h 21m | Avg: 19m 08s | Max: 1h 18m | Hits: 90%/53485 

    🟩 cpu
  🟩 amd64              Pass: 100%/43  | Total: 14h 10m | Avg: 19m 46s | Max:  1h 18m | Hits:  89%/51055 
  🟩 arm64              Pass: 100%/2   | Total: 10m 48s | Avg:  5m 24s | Max:  5m 38s | Hits:  99%/2430  
🟩 ctk
  🟩 12.0               Pass: 100%/5   | Total:  1h 24m | Avg: 16m 56s | Max:  1h 02m | Hits:  85%/5908  
  🟩 12.5               Pass: 100%/2   | Total:  2h 14m | Avg:  1h 07m | Max:  1h 10m | Hits:  65%/2248  
  🟩 12.8               Pass: 100%/38  | Total: 10h 42m | Avg: 16m 54s | Max:  1h 18m | Hits:  92%/45329 
🟩 cudacxx
  🟩 ClangCUDA18        Pass: 100%/2   | Total:  9m 53s | Avg:  4m 56s | Max:  5m 03s | Hits: 100%/2100  
  🟩 nvcc12.0           Pass: 100%/5   | Total:  1h 24m | Avg: 16m 56s | Max:  1h 02m | Hits:  85%/5908  
  🟩 nvcc12.5           Pass: 100%/2   | Total:  2h 14m | Avg:  1h 07m | Max:  1h 10m | Hits:  65%/2248  
  🟩 nvcc12.8           Pass: 100%/36  | Total: 10h 32m | Avg: 17m 34s | Max:  1h 18m | Hits:  91%/43229 
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/2   | Total:  9m 53s | Avg:  4m 56s | Max:  5m 03s | Hits: 100%/2100  
  🟩 nvcc               Pass: 100%/43  | Total: 14h 11m | Avg: 19m 48s | Max:  1h 18m | Hits:  90%/51385 
🟩 cxx
  🟩 Clang14            Pass: 100%/4   | Total: 22m 46s | Avg:  5m 41s | Max:  5m 59s | Hits: 100%/4868  
  🟩 Clang15            Pass: 100%/2   | Total: 12m 15s | Avg:  6m 07s | Max:  6m 16s | Hits: 100%/2430  
  🟩 Clang16            Pass: 100%/2   | Total: 12m 28s | Avg:  6m 14s | Max:  6m 20s | Hits: 100%/2430  
  🟩 Clang17            Pass: 100%/2   | Total: 12m 16s | Avg:  6m 08s | Max:  6m 26s | Hits: 100%/2430  
  🟩 Clang18            Pass: 100%/7   | Total:  1h 12m | Avg: 10m 19s | Max: 23m 27s | Hits: 100%/8175  
  🟩 GCC7               Pass: 100%/2   | Total: 11m 35s | Avg:  5m 47s | Max:  5m 59s | Hits:  99%/2434  
  🟩 GCC8               Pass: 100%/1   | Total:  6m 07s | Avg:  6m 07s | Max:  6m 07s | Hits:  99%/1217  
  🟩 GCC9               Pass: 100%/2   | Total: 12m 07s | Avg:  6m 03s | Max:  6m 21s | Hits:  99%/2434  
  🟩 GCC10              Pass: 100%/2   | Total: 12m 57s | Avg:  6m 28s | Max:  6m 44s | Hits:  99%/2434  
  🟩 GCC11              Pass: 100%/2   | Total: 13m 04s | Avg:  6m 32s | Max:  6m 47s | Hits:  99%/2430  
  🟩 GCC12              Pass: 100%/2   | Total: 13m 11s | Avg:  6m 35s | Max:  6m 52s | Hits:  99%/2430  
  🟩 GCC13              Pass: 100%/11  | Total:  4h 05m | Avg: 22m 16s | Max:  1h 10m | Hits:  93%/13365 
  🟩 MSVC14.29          Pass: 100%/2   | Total:  2h 11m | Avg:  1h 05m | Max:  1h 09m | Hits:  15%/2080  
  🟩 MSVC14.42          Pass: 100%/2   | Total:  2h 29m | Avg:  1h 14m | Max:  1h 18m | Hits:  15%/2080  
  🟩 NVHPC24.7          Pass: 100%/2   | Total:  2h 14m | Avg:  1h 07m | Max:  1h 10m | Hits:  65%/2248  
🟩 cxx_family
  🟩 Clang              Pass: 100%/17  | Total:  2h 12m | Avg:  7m 45s | Max: 23m 27s | Hits: 100%/20333 
  🟩 GCC                Pass: 100%/22  | Total:  5h 14m | Avg: 14m 16s | Max:  1h 10m | Hits:  96%/26744 
  🟩 MSVC               Pass: 100%/4   | Total:  4h 40m | Avg:  1h 10m | Max:  1h 18m | Hits:  15%/4160  
  🟩 NVHPC              Pass: 100%/2   | Total:  2h 14m | Avg:  1h 07m | Max:  1h 10m | Hits:  65%/2248  
🟩 gpu
  🟩 h100               Pass: 100%/3   | Total:  1h 10m | Avg: 23m 25s | Max: 25m 56s | Hits:  89%/3645  
  🟩 rtx2080            Pass: 100%/34  | Total: 10h 48m | Avg: 19m 04s | Max:  1h 18m | Hits:  88%/40120 
  🟩 rtxa6000           Pass: 100%/8   | Total:  2h 22m | Avg: 17m 50s | Max: 24m 19s | Hits:  99%/9720  
🟩 jobs
  🟩 Build              Pass: 100%/37  | Total: 11h 26m | Avg: 18m 33s | Max:  1h 18m | Hits:  88%/43765 
  🟩 DeviceLaunch       Pass: 100%/1   | Total: 22m 11s | Avg: 22m 11s | Max: 22m 11s | Hits:  99%/1215  
  🟩 GraphCapture       Pass: 100%/1   | Total: 16m 04s | Avg: 16m 04s | Max: 16m 04s | Hits:  99%/1215  
  🟩 HostLaunch         Pass: 100%/3   | Total:  1h 10m | Avg: 23m 31s | Max: 24m 19s | Hits:  99%/3645  
  🟩 TestGPU            Pass: 100%/3   | Total:  1h 05m | Avg: 21m 59s | Max: 22m 34s | Hits:  99%/3645  
🟩 sm
  🟩 90                 Pass: 100%/3   | Total:  1h 10m | Avg: 23m 25s | Max: 25m 56s | Hits:  89%/3645  
  🟩 90;90a;100         Pass: 100%/1   | Total:  1h 10m | Avg:  1h 10m | Max:  1h 10m | Hits:  67%/1215  
🟩 std
  🟩 17                 Pass: 100%/20  | Total:  6h 10m | Avg: 18m 32s | Max:  1h 18m | Hits:  87%/23535 
  🟩 20                 Pass: 100%/25  | Total:  8h 10m | Avg: 19m 37s | Max:  1h 11m | Hits:  93%/29950

  • 🟩 thrust: Pass: 100%/45 | Total: 9h 23m | Avg: 12m 30s | Max: 44m 15s | Hits: 94%/80136 

    🟩 cmake_options
  🟩 -DTHRUST_DISPATCH_TYPE=Force32bit Pass: 100%/2   | Total: 17m 09s | Avg:  8m 34s | Max: 11m 02s | Hits:  99%/3564  
🟩 cpu
  🟩 amd64              Pass: 100%/43  | Total:  9h 13m | Avg: 12m 52s | Max: 44m 15s | Hits:  94%/76573 
  🟩 arm64              Pass: 100%/2   | Total:  9m 34s | Avg:  4m 47s | Max:  5m 09s | Hits:  99%/3563  
🟩 ctk
  🟩 12.0               Pass: 100%/5   | Total: 59m 54s | Avg: 11m 58s | Max: 40m 21s | Hits:  94%/8901  
  🟩 12.5               Pass: 100%/2   | Total:  1h 28m | Avg: 44m 05s | Max: 44m 15s | Hits:  74%/3562  
  🟩 12.8               Pass: 100%/38  | Total:  6h 55m | Avg: 10m 55s | Max: 43m 36s | Hits:  95%/67673 
🟩 cudacxx
  🟩 ClangCUDA18        Pass: 100%/2   | Total: 10m 30s | Avg:  5m 15s | Max:  5m 23s | Hits: 100%/3562  
  🟩 nvcc12.0           Pass: 100%/5   | Total: 59m 54s | Avg: 11m 58s | Max: 40m 21s | Hits:  94%/8901  
  🟩 nvcc12.5           Pass: 100%/2   | Total:  1h 28m | Avg: 44m 05s | Max: 44m 15s | Hits:  74%/3562  
  🟩 nvcc12.8           Pass: 100%/36  | Total:  6h 44m | Avg: 11m 14s | Max: 43m 36s | Hits:  95%/64111 
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/2   | Total: 10m 30s | Avg:  5m 15s | Max:  5m 23s | Hits: 100%/3562  
  🟩 nvcc               Pass: 100%/43  | Total:  9h 12m | Avg: 12m 51s | Max: 44m 15s | Hits:  94%/76574 
🟩 cxx
  🟩 Clang14            Pass: 100%/4   | Total: 20m 57s | Avg:  5m 14s | Max:  5m 44s | Hits: 100%/7124  
  🟩 Clang15            Pass: 100%/2   | Total: 11m 14s | Avg:  5m 37s | Max:  5m 42s | Hits: 100%/3562  
  🟩 Clang16            Pass: 100%/2   | Total: 11m 02s | Avg:  5m 31s | Max:  5m 42s | Hits: 100%/3562  
  🟩 Clang17            Pass: 100%/2   | Total: 10m 38s | Avg:  5m 19s | Max:  5m 26s | Hits: 100%/3562  
  🟩 Clang18            Pass: 100%/7   | Total: 42m 49s | Avg:  6m 07s | Max: 10m 08s | Hits: 100%/12467 
  🟩 GCC7               Pass: 100%/2   | Total: 10m 22s | Avg:  5m 11s | Max:  5m 35s | Hits:  99%/3564  
  🟩 GCC8               Pass: 100%/1   | Total:  5m 06s | Avg:  5m 06s | Max:  5m 06s | Hits:  99%/1782  
  🟩 GCC9               Pass: 100%/2   | Total: 10m 02s | Avg:  5m 01s | Max:  5m 15s | Hits:  99%/3564  
  🟩 GCC10              Pass: 100%/2   | Total: 11m 57s | Avg:  5m 58s | Max:  6m 10s | Hits:  99%/3564  
  🟩 GCC11              Pass: 100%/2   | Total: 10m 51s | Avg:  5m 25s | Max:  5m 35s | Hits:  99%/3564  
  🟩 GCC12              Pass: 100%/2   | Total: 12m 15s | Avg:  6m 07s | Max:  6m 14s | Hits:  99%/3564  
  🟩 GCC13              Pass: 100%/10  | Total:  1h 54m | Avg: 11m 27s | Max: 33m 14s | Hits:  95%/17820 
  🟩 MSVC14.29          Pass: 100%/2   | Total:  1h 22m | Avg: 41m 17s | Max: 42m 14s | Hits:  70%/3550  
  🟩 MSVC14.42          Pass: 100%/3   | Total:  2h 00m | Avg: 40m 11s | Max: 43m 36s | Hits:  70%/5325  
  🟩 NVHPC24.7          Pass: 100%/2   | Total:  1h 28m | Avg: 44m 05s | Max: 44m 15s | Hits:  74%/3562  
🟩 cxx_family
  🟩 Clang              Pass: 100%/17  | Total:  1h 36m | Avg:  5m 41s | Max: 10m 08s | Hits: 100%/30277 
  🟩 GCC                Pass: 100%/21  | Total:  2h 55m | Avg:  8m 20s | Max: 33m 14s | Hits:  97%/37422 
  🟩 MSVC               Pass: 100%/5   | Total:  3h 23m | Avg: 40m 38s | Max: 43m 36s | Hits:  70%/8875  
  🟩 NVHPC              Pass: 100%/2   | Total:  1h 28m | Avg: 44m 05s | Max: 44m 15s | Hits:  74%/3562  
🟩 gpu
  🟩 h100               Pass: 100%/2   | Total: 27m 55s | Avg: 13m 57s | Max: 16m 24s | Hits:  89%/3564  
  🟩 rtx2080            Pass: 100%/33  | Total:  6h 32m | Avg: 11m 54s | Max: 44m 15s | Hits:  95%/58769 
  🟩 rtx4090            Pass: 100%/10  | Total:  2h 22m | Avg: 14m 14s | Max: 43m 02s | Hits:  94%/17803 
🟩 jobs
  🟩 Build              Pass: 100%/38  | Total:  7h 49m | Avg: 12m 21s | Max: 44m 15s | Hits:  94%/67671 
  🟩 TestCPU            Pass: 100%/3   | Total: 49m 32s | Avg: 16m 30s | Max: 33m 57s | Hits:  90%/5338  
  🟩 TestGPU            Pass: 100%/4   | Total: 43m 59s | Avg: 10m 59s | Max: 11m 31s | Hits:  99%/7127  
🟩 sm
  🟩 90                 Pass: 100%/2   | Total: 27m 55s | Avg: 13m 57s | Max: 16m 24s | Hits:  89%/3564  
  🟩 90;90a;100         Pass: 100%/1   | Total: 33m 14s | Avg: 33m 14s | Max: 33m 14s | Hits:  79%/1782  
🟩 std
  🟩 17                 Pass: 100%/20  | Total:  4h 16m | Avg: 12m 49s | Max: 44m 15s | Hits:  94%/35611 
  🟩 20                 Pass: 100%/23  | Total:  4h 49m | Avg: 12m 34s | Max: 43m 56s | Hits:  94%/40961

  • 🟩 cccl_c_parallel: Pass: 100%/2 | Total: 15m 30s | Avg: 7m 45s | Max: 12m 51s | Hits: 98%/308 

    🟩 cpu
  🟩 amd64              Pass: 100%/2   | Total: 15m 30s | Avg:  7m 45s | Max: 12m 51s | Hits:  98%/308   
🟩 ctk
  🟩 12.8               Pass: 100%/2   | Total: 15m 30s | Avg:  7m 45s | Max: 12m 51s | Hits:  98%/308   
🟩 cudacxx
  🟩 nvcc12.8           Pass: 100%/2   | Total: 15m 30s | Avg:  7m 45s | Max: 12m 51s | Hits:  98%/308   
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/2   | Total: 15m 30s | Avg:  7m 45s | Max: 12m 51s | Hits:  98%/308   
🟩 cxx
  🟩 GCC13              Pass: 100%/2   | Total: 15m 30s | Avg:  7m 45s | Max: 12m 51s | Hits:  98%/308   
🟩 cxx_family
  🟩 GCC                Pass: 100%/2   | Total: 15m 30s | Avg:  7m 45s | Max: 12m 51s | Hits:  98%/308   
🟩 gpu
  🟩 rtx2080            Pass: 100%/2   | Total: 15m 30s | Avg:  7m 45s | Max: 12m 51s | Hits:  98%/308   
🟩 jobs
  🟩 Build              Pass: 100%/1   | Total:  2m 39s | Avg:  2m 39s | Max:  2m 39s | Hits:  97%/154   
  🟩 Test               Pass: 100%/1   | Total: 12m 51s | Avg: 12m 51s | Max: 12m 51s | Hits:  98%/154

  • 🟩 python: Pass: 100%/1 | Total: 40m 20s | Avg: 40m 20s | Max: 40m 20s

     
    🟩 cpu
  🟩 amd64              Pass: 100%/1   | Total: 40m 20s | Avg: 40m 20s | Max: 40m 20s
🟩 ctk
  🟩 12.8               Pass: 100%/1   | Total: 40m 20s | Avg: 40m 20s | Max: 40m 20s
🟩 cudacxx
  🟩 nvcc12.8           Pass: 100%/1   | Total: 40m 20s | Avg: 40m 20s | Max: 40m 20s
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/1   | Total: 40m 20s | Avg: 40m 20s | Max: 40m 20s
🟩 cxx
  🟩 GCC13              Pass: 100%/1   | Total: 40m 20s | Avg: 40m 20s | Max: 40m 20s
🟩 cxx_family
  🟩 GCC                Pass: 100%/1   | Total: 40m 20s | Avg: 40m 20s | Max: 40m 20s
🟩 gpu
  🟩 rtx2080            Pass: 100%/1   | Total: 40m 20s | Avg: 40m 20s | Max: 40m 20s
🟩 jobs
  🟩 Test               Pass: 100%/1   | Total: 40m 20s | Avg: 40m 20s | Max: 40m 20s

👃 Inspect Changes

Modifications in project?

Project
CCCL Infrastructure
libcu++
+/- CUB
Thrust
CUDA Experimental
python
CCCL C Parallel Library
Catch2Helper

Modifications in project or dependencies?

Project
CCCL Infrastructure
libcu++
+/- CUB
+/- Thrust
CUDA Experimental
+/- python
+/- CCCL C Parallel Library
+/- Catch2Helper

🏃‍ Runner counts (total jobs: 93)
# Runner
66 linux-amd64-cpu16
9 windows-amd64-cpu16
6 linux-amd64-gpu-rtxa6000-latest-1
4 linux-arm64-cpu16
3 linux-amd64-gpu-h100-latest-1
3 linux-amd64-gpu-rtx4090-latest-1
2 linux-amd64-gpu-rtx2080-latest-1

@elstehle elstehle merged commit 9348b8f into NVIDIA:main Feb 23, 2025
106 of 109 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elstehle elstehle elstehle approved these changes

@gevtushenko gevtushenko Awaiting requested review from gevtushenko gevtushenko is a code owner automatically assigned from NVIDIA/cccl-cub-codeowners

Assignees
No one assigned
Labels
None yet
Projects
CCCL
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brycelelbach @elstehle