fix: reduce window for multiprocessing race #1464
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1414 exposed an underlying race condition when using multi-processing capable generators, that are stored in a probe, on the primary execution thread. Serialization leaves the generator in a state that requires client connections to be rebuilt and usage of locks to guard
_call_modelwould introduce further issue in serialization for multiprocessing actions.By storing local references to the client objects during inference calls the serialization side-effects are limited to a much smaller runtime window
Further work is needed to remove the race condition fully, this is simply a short term mitigation until a more complete refactor can be designed.
Verification
List the steps needed to make sure this thing works