Move chatty logs from INFO to DEBUG#346
Merged
shurkat-nvidia merged 3 commits intoJun 5, 2026
Merged
Conversation
Contributor
Greptile SummaryThis PR reduces log noise by demoting three lifecycle messages in
Confidence Score: 5/5Safe to merge — the change is a targeted log-level adjustment with no functional impact on the checkpointing logic. All three changes are isolated to logger call sites and do not touch any checkpoint scheduling, worker lifecycle, or data-handling code paths. The rank-conditional pattern applied in both _start_worker and close is consistent and matches the stated intent of the PR. No files require special attention. Important Files Changed
Sequence DiagramsequenceDiagram
participant R0 as Rank 0
participant RN as Rank N (N>0)
participant LOG as Logger
Note over R0,LOG: _start_worker
R0->>LOG: INFO "PersistentAsyncCaller: 0, Starting Async Caller"
RN->>LOG: DEBUG "PersistentAsyncCaller: N, Starting Async Caller"
Note over R0,LOG: close
R0->>LOG: INFO "PersistentAsyncCaller: 0, Destroying Async Caller"
RN->>LOG: DEBUG "PersistentAsyncCaller: N, Destroying Async Caller"
Note over R0,LOG: cleanup_worker_data_cache (classmethod)
R0->>LOG: DEBUG "Cleaning up worker data cache with X entries"
RN->>LOG: DEBUG "Cleaning up worker data cache with X entries"
Reviews (4): Last reviewed commit: "Make destroying messages symmetric with ..." | Re-trigger Greptile |
ankurv-nvidia
previously approved these changes
Jun 4, 2026
Moves the following three logs from INFO to DEBUG levels - PersistentAsyncCaller: ..., Starting Async Caller - PersistentAsyncCaller: ..., Destroying Async Caller - Cleaning up worker data cache with ... entries Keeps only rank 0 at INFO level for "PersistentAsyncCaller: ...", but all ranks to DEBUG for "Cleaning up worker data cache"
99e9fd0 to
1e94053
Compare
ankurv-nvidia
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the following three logs from INFO to DEBUG levels
Keeps only rank 0 at INFO level for "PersistentAsyncCaller: ...", but all ranks to DEBUG for "Cleaning up worker data cache"