Enhance crash recipe with configurable stats directory#1466
Open
dran-dev wants to merge 1 commit intoNVIDIA:mainfrom
Open
Enhance crash recipe with configurable stats directory#1466dran-dev wants to merge 1 commit intoNVIDIA:mainfrom
dran-dev wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
cec7407 to
7f6061f
Compare
Contributor
Greptile SummaryThis PR successfully adds a configurable Key improvements:
Implementation approach: The solution is clean and minimal, with good backward compatibility. Important Files Changed
Last reviewed commit: 7f6061f |
examples/structural_mechanics/crash/conf/datapipe/point_cloud.yaml
Outdated
Show resolved
Hide resolved
Contributor
Author
|
/blossom-ci |
7f6061f to
461515b
Compare
Added support for a configurable stats directory in train.py, inference.py for crash recipe. Signed-off-by: Dileep Ranganathan <8152399+dran-dev@users.noreply.github.com>
461515b to
b548ef7
Compare
Contributor
Author
|
@mnabian @ktangsali PTAL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PhysicsNeMo Pull Request
Description
Make the stats directory (
node_stats.json,feature_stats.json,edge_stats.json) configurable via Hydra in the crash simulation recipe.Previously, training wrote normalization statistics to a relative
./stats/path under the Hydra run output directory. During inference, a different Hydra
output directory is used, so the stats files were not found — resulting in:
This PR adds a
datapipe.stats_dirconfiguration option (defaulting tonull, which preserves the existing./stats/behavior) so users canpoint inference to the training run's stats directory:
Changes
stats_dirparameter toCrashBaseDataset.__init__withbackward-compatible default (
Nonefalls back to relativestats/).stats_dir: nulltopoint_cloud.yamlandgraph.yamldatapipe configs.
datapipe.py,train.py, andinference.py.datapipe.stats_diroption.Checklist
Dependencies
None.