Update Compilers in Test Workflow (#373)

jwaldrop107 · web-flow · commit 4f4381a864eb · 2025-11-19T21:43:53.000-06:00
* Update Compilers in Test Workflow

* address copy elision warning
diff --git a/.github/workflows/pull_request.yaml b/.github/workflows/pull_request.yaml
@@ -32,4 +32,4 @@ jobs:
   test_library:
     uses: NWChemEx/.github/.github/workflows/test_nwx_library.yaml@master
     with:
-      compilers: '["gcc-11", "clang-14"]'
+      compilers: '["gcc-14", "clang-19"]'
diff --git a/include/pluginplay/fields/module_input.ipp b/include/pluginplay/fields/module_input.ipp
@@ -120,7 +120,7 @@ auto& ModuleInput::change(T&& new_value) {
     if constexpr(detail_::IsCString<T>::value) {
         change_(wrap_value_(std::string(new_value)));
     } else {
-        change_(std::move(wrap_value_(std::forward<T>(new_value))));
+        change_(wrap_value_(std::forward<T>(new_value)));
     }
     return *this;
 }
diff --git a/include/pluginplay/fields/module_result.ipp b/include/pluginplay/fields/module_result.ipp
@@ -46,7 +46,7 @@ void ModuleResult::change(T&& new_value) {
     else if constexpr(detail_::IsCString<T>::value)
         change_(wrap_value_(std::string(new_value)));
     else
-        change_(std::move(wrap_value_(std::forward<T>(new_value))));
+        change_(wrap_value_(std::forward<T>(new_value)));
 }
 
 template<typename T>

Original file line number	Diff line number	Diff line change
`@@ -120,7 +120,7 @@ auto& ModuleInput::change(T&& new_value) {`
`120`	`120`	`if constexpr(detail_::IsCString<T>::value) {`
`121`	`121`	`change_(wrap_value_(std::string(new_value)));`
`122`	`122`	`} else {`
`123`		`- change_(std::move(wrap_value_(std::forward<T>(new_value))));`
	`123`	`+ change_(wrap_value_(std::forward<T>(new_value)));`
`124`	`124`	`}`
`125`	`125`	`return *this;`
`126`	`126`	`}`
Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,7 @@ void ModuleResult::change(T&& new_value) {`
`46`	`46`	`else if constexpr(detail_::IsCString<T>::value)`
`47`	`47`	`change_(wrap_value_(std::string(new_value)));`
`48`	`48`	`else`
`49`		`- change_(std::move(wrap_value_(std::forward<T>(new_value))));`
	`49`	`+ change_(wrap_value_(std::forward<T>(new_value)));`
`50`	`50`	`}`
`51`	`51`
`52`	`52`	`template<typename T>`