Skip to content

Commit aaa53ee

Browse files
Update ml7238.md
1 parent f7b1e70 commit aaa53ee

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

src/design_notebooks/2024spring/ml7238.md

+2
Original file line numberDiff line numberDiff line change
@@ -142,4 +142,6 @@ Project Work:
142142
* [Fixed Con_ID Tests Not Running](https://github.com/NYU-Processor-Design/nyu-core/pull/173): Fixed an issue where the Con_ID tests were not running since the CMake files had not been updated to include them.
143143
* [Optimized Core Tests to Run Faster](https://github.com/NYU-Processor-Design/nyu-core/pull/173): Made various changes and optimizations to the tests to bring the GitHub run time down from 4 hours to 30 minutes.
144144

145+
We finally figured out the Verilator issue with `has_virtual_destructor`, turns out they forgot to <type_traits>, so I had Vito walk me through manually modifying my Verilator installation to add the missing include. I then spent a good chunk of time trying to shard the core tests so they could run multithreaded only for Vito to tell me that I could just run `ctest -j [number of threads]` which was much simpler. Once that was figured out, I went through the various core tests and optimized them to reduce run time. I was able to get the test time on GitHub down from 4 hours to 30 minutes, and just a couple of minutes locally.
145146

147+
This will be my last design notebook entry as I am graduating, so I merged my changes to the L1 Data Cache and its test. I still plan to continue work on the core but at a much less frequent pace; I also plan to continue to be available in the Discord to help people and guide Camereon and Xingzhi through taking over the Core Czar role.

0 commit comments

Comments
 (0)