chore: string comparison perf note feedback

NathanWalker · Copilot · web-flow · commit 1f348ed95320 · 2025-11-06T13:37:52.000-08:00
Co-authored-by: Copilot &lt;175728472+Copilot@users.noreply.github.com&gt;
diff --git a/test-app/runtime/src/main/cpp/ModuleInternalCallbacks.cpp b/test-app/runtime/src/main/cpp/ModuleInternalCallbacks.cpp
@@ -70,7 +70,7 @@ static void LogHttpCompileDiagnostics(v8::Isolate* isolate,
             classification = "wrap-error";
         }
     }
-    if (std::string(classification) == "unknown") {
+    if (strcmp(classification, "unknown") == 0) {
         if (code.find("export default") == std::string::npos && code.find("__sfc__") != std::string::npos) classification = "missing-export-default";
         else if (code.find("__sfc__") != std::string::npos && code.find("export {") == std::string::npos && code.find("export ") == std::string::npos) classification = "no-exports";
         else if (code.find("import ") == std::string::npos && code.find("export ") == std::string::npos) classification = "not-module";

Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,7 @@ static void LogHttpCompileDiagnostics(v8::Isolate* isolate,`
`70`	`70`	`classification = "wrap-error";`
`71`	`71`	`}`
`72`	`72`	`}`
`73`		`- if (std::string(classification) == "unknown") {`
	`73`	`+ if (strcmp(classification, "unknown") == 0) {`
`74`	`74`	`if (code.find("export default") == std::string::npos && code.find("__sfc__") != std::string::npos) classification = "missing-export-default";`
`75`	`75`	`else if (code.find("__sfc__") != std::string::npos && code.find("export {") == std::string::npos && code.find("export ") == std::string::npos) classification = "no-exports";`
`76`	`76`	`else if (code.find("import ") == std::string::npos && code.find("export ") == std::string::npos) classification = "not-module";`