Skip to content

Commit 4e37c7a

Browse files
committed
fix(firestore): field value
1 parent 721e850 commit 4e37c7a

File tree

4 files changed

+11
-32
lines changed

4 files changed

+11
-32
lines changed

packages/firebase-firestore/common.ts

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -71,18 +71,7 @@ export interface IFieldPath {
7171
documentId(): IFieldPath;
7272
}
7373

74-
export interface IFieldValue {
75-
76-
arrayRemove(elements: any[]): IFieldValue;
77-
78-
arrayUnion(elements: any[]): IFieldValue;
79-
80-
delete(): IFieldValue;
81-
82-
increment(n: number): IFieldValue;
83-
84-
serverTimestamp(): IFieldValue;
85-
}
74+
export interface IFieldValue {}
8675

8776
export interface IGeoPoint {
8877
latitude: number;

packages/firebase-firestore/index.android.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1241,23 +1241,23 @@ export class FieldValue implements IFieldValue {
12411241
}
12421242

12431243

1244-
arrayRemove(elements: any[]): FieldValue {
1244+
static arrayRemove(elements: any[]): FieldValue {
12451245
return FieldValue.fromNative(com.google.firebase.firestore.FieldValue.arrayRemove(elements.map((element) => element?.native || element)));
12461246
}
12471247

1248-
arrayUnion(elements: any[]): FieldValue {
1248+
static arrayUnion(elements: any[]): FieldValue {
12491249
return FieldValue.fromNative(com.google.firebase.firestore.FieldValue.arrayUnion(elements.map((element) => element?.native || element)));
12501250
}
12511251

1252-
delete(): FieldValue {
1252+
static delete(): FieldValue {
12531253
return FieldValue.fromNative(com.google.firebase.firestore.FieldValue.delete());
12541254
}
12551255

1256-
increment(n: number): FieldValue {
1256+
static increment(n: number): FieldValue {
12571257
return FieldValue.fromNative(com.google.firebase.firestore.FieldValue.increment(n));
12581258
}
12591259

1260-
serverTimestamp(): FieldValue {
1260+
static serverTimestamp(): FieldValue {
12611261
return FieldValue.fromNative(com.google.firebase.firestore.FieldValue.serverTimestamp());
12621262
}
12631263

packages/firebase-firestore/index.d.ts

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -183,16 +183,6 @@ export declare class FieldPath implements IFieldPath {
183183
}
184184

185185
export declare class FieldValue implements IFieldValue {
186-
arrayRemove(elements: any[]): FieldValue;
187-
188-
arrayUnion(elements: any[]): FieldValue;
189-
190-
delete(): FieldValue;
191-
192-
increment(n: number): FieldValue;
193-
194-
serverTimestamp(): FieldValue;
195-
196186
readonly android: any;
197187
readonly ios: any;
198188
readonly native: any;

packages/firebase-firestore/index.ios.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1079,27 +1079,27 @@ export class FieldValue implements IFieldValue {
10791079
}
10801080

10811081

1082-
arrayRemove(elements: any[]): FieldValue {
1082+
static arrayRemove(elements: any[]): FieldValue {
10831083
return FieldValue.fromNative(FIRFieldValue.fieldValueForArrayRemove(elements.map((element) => element?.native || element)));
10841084
}
10851085

1086-
arrayUnion(elements: any[]): FieldValue {
1086+
static arrayUnion(elements: any[]): FieldValue {
10871087
return FieldValue.fromNative(FIRFieldValue.fieldValueForArrayUnion(elements.map((element) => element?.native || element)));
10881088
}
10891089

1090-
delete(): FieldValue {
1090+
static delete(): FieldValue {
10911091
return FieldValue.fromNative(FIRFieldValue.fieldValueForDelete());
10921092
}
10931093

1094-
increment(n: number): FieldValue {
1094+
static increment(n: number): FieldValue {
10951095
const useDouble = n % 1 === 0;
10961096
if (useDouble) {
10971097
return FieldValue.fromNative(FIRFieldValue.fieldValueForDoubleIncrement(n));
10981098
}
10991099
return FieldValue.fromNative(FIRFieldValue.fieldValueForIntegerIncrement(n));
11001100
}
11011101

1102-
serverTimestamp(): FieldValue {
1102+
static serverTimestamp(): FieldValue {
11031103
return FieldValue.fromNative(FIRFieldValue.fieldValueForServerTimestamp());
11041104
}
11051105

0 commit comments

Comments
 (0)