From 7f6d41ffb07edaff8a129a735ee56f69edc8f167 Mon Sep 17 00:00:00 2001 From: Matthias Zach Date: Wed, 14 May 2025 12:18:24 +0200 Subject: [PATCH 1/3] Update the ring interface docu. --- docs/src/ring_interface.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/src/ring_interface.md b/docs/src/ring_interface.md index 2897b856d2..02e97006d5 100644 --- a/docs/src/ring_interface.md +++ b/docs/src/ring_interface.md @@ -505,6 +505,8 @@ throwing an exception, returning meaningless results, hanging or crashing. The function should only be called with `check=false` if it is already known that the division will be exact. +***Note:*** For the *recursive* ring tests to work, one needs to also implement `divides(f::MyElem, g::MyElem)`. + ### Inverse ```julia From 5759ae54e4d1530a34edafd3029ccf8b631b5dfd Mon Sep 17 00:00:00 2001 From: Matthias Zach Date: Wed, 14 May 2025 12:26:04 +0200 Subject: [PATCH 2/3] Add type assertion for empty lists. --- src/MPoly.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/MPoly.jl b/src/MPoly.jl index 90f8e30e68..22b7ca0ffb 100644 --- a/src/MPoly.jl +++ b/src/MPoly.jl @@ -1467,7 +1467,7 @@ function ConformanceTests.generate_element(Rx::MPolyRing) len_bound = 8 exp_bound = rand(1:5) len = rand(0:len_bound) - coeffs = [ConformanceTests.generate_element(R) for _ in 1:len] + coeffs = elem_type(R)[ConformanceTests.generate_element(R) for _ in 1:len] exps = [[rand(0:exp_bound) for _ in 1:num_gens] for _ in 1:len] return Rx(coeffs, exps) end From f520650151a98070f137f63bda78fa0c1497c58c Mon Sep 17 00:00:00 2001 From: Matthias Zach Date: Fri, 23 May 2025 15:21:00 +0200 Subject: [PATCH 3/3] Revert "Update the ring interface docu." This reverts commit 7f6d41ffb07edaff8a129a735ee56f69edc8f167. --- docs/src/ring_interface.md | 2 -- 1 file changed, 2 deletions(-) diff --git a/docs/src/ring_interface.md b/docs/src/ring_interface.md index 02e97006d5..2897b856d2 100644 --- a/docs/src/ring_interface.md +++ b/docs/src/ring_interface.md @@ -505,8 +505,6 @@ throwing an exception, returning meaningless results, hanging or crashing. The function should only be called with `check=false` if it is already known that the division will be exact. -***Note:*** For the *recursive* ring tests to work, one needs to also implement `divides(f::MyElem, g::MyElem)`. - ### Inverse ```julia