Skip to content

Refactor: Use pressure-based calculations in GasPlanner and OxygenToxicityCalculator - #180

Merged
Rolf-Smit merged 1 commit into
mainfrom
feature/pressure-based-oxygen-toxicity-calculations
May 5, 2026
Merged

Refactor: Use pressure-based calculations in GasPlanner and OxygenToxicityCalculator#180
Rolf-Smit merged 1 commit into
mainfrom
feature/pressure-based-oxygen-toxicity-calculations

Conversation

@Rolf-Smit

Copy link
Copy Markdown
Contributor

GasPlanner and OxygenToxicityCalculator now use pressures directly. Meter-based helper functions on the Gas type have been replaced with pressure-based ones.

Required for: #49

@Rolf-Smit
Rolf-Smit force-pushed the feature/pressure-based-oxygen-toxicity-calculations branch 2 times, most recently from d64bdf0 to 7f0913a Compare May 5, 2026 00:16
…icityCalculator

`GasPlanner` and `OxygenToxicityCalculator` now use pressures directly. Meter-based helper functions on the `Gas` type have been replaced with pressure-based ones.

Required for: #49
@Rolf-Smit
Rolf-Smit force-pushed the feature/pressure-based-oxygen-toxicity-calculations branch from 7f0913a to aa039c7 Compare May 5, 2026 00:30
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 54.09836% with 28 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.14%. Comparing base (80009a5) to head (aa039c7).

Files with missing lines Patch % Lines
.../app/abysner/domain/diveplanning/model/DivePlan.kt 0.00% 8 Missing ⚠️
...r/presentation/component/GasPropertiesComponent.kt 46.15% 3 Missing and 4 partials ⚠️
...reens/planner/segments/SegmentPickerBottomSheet.kt 30.00% 2 Missing and 5 partials ⚠️
...otech/app/abysner/domain/gasplanning/GasPlanner.kt 70.00% 0 Missing and 3 partials ⚠️
...ion/screens/planner/DiveEditorViewModelDelegate.kt 0.00% 0 Missing and 1 partial ⚠️
...resentation/screens/planner/PlanScreenViewModel.kt 50.00% 0 Missing and 1 partial ⚠️
...n/org/neotech/app/abysner/domain/core/model/Gas.kt 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #180      +/-   ##
==========================================
- Coverage   70.15%   70.14%   -0.02%     
==========================================
  Files         145      145              
  Lines        7847     7840       -7     
  Branches      977      978       +1     
==========================================
- Hits         5505     5499       -6     
+ Misses       1851     1849       -2     
- Partials      491      492       +1     
Flag Coverage Δ
domain 78.13% <63.63%> (-0.02%) ⬇️
presentation 68.12% <42.85%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Rolf-Smit
Rolf-Smit merged commit 854b5ec into main May 5, 2026
4 checks passed
@Rolf-Smit
Rolf-Smit deleted the feature/pressure-based-oxygen-toxicity-calculations branch May 5, 2026 06:42
@github-actions github-actions Bot locked and limited conversation to collaborators May 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants