Refactor: Use pressure-based calculations in GasPlanner and OxygenToxicityCalculator - #180
Merged
Rolf-Smit merged 1 commit intoMay 5, 2026
Conversation
Rolf-Smit
force-pushed
the
feature/pressure-based-oxygen-toxicity-calculations
branch
2 times, most recently
from
May 5, 2026 00:16
d64bdf0 to
7f0913a
Compare
…icityCalculator `GasPlanner` and `OxygenToxicityCalculator` now use pressures directly. Meter-based helper functions on the `Gas` type have been replaced with pressure-based ones. Required for: #49
Rolf-Smit
force-pushed
the
feature/pressure-based-oxygen-toxicity-calculations
branch
from
May 5, 2026 00:30
7f0913a to
aa039c7
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #180 +/- ##
==========================================
- Coverage 70.15% 70.14% -0.02%
==========================================
Files 145 145
Lines 7847 7840 -7
Branches 977 978 +1
==========================================
- Hits 5505 5499 -6
+ Misses 1851 1849 -2
- Partials 491 492 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GasPlannerandOxygenToxicityCalculatornow use pressures directly. Meter-based helper functions on theGastype have been replaced with pressure-based ones.Required for: #49