Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails on festival charts if \r in end of lines #49

Open
shacha086 opened this issue Sep 10, 2024 · 5 comments
Open

Fails on festival charts if \r in end of lines #49

shacha086 opened this issue Sep 10, 2024 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@shacha086
Copy link

大概是PythonNET的问题但是还是想求助一下
自己debug了下发现函数中的connectedSlides永远为空,大概是这一块相关逻辑有问题?
稍后上传一个最小可复现样本

@shacha086
Copy link
Author

发现复现不出来了(?)我先close吧 打扰了

@shacha086 shacha086 changed the title ComposeSlideGroup in Chart class failed when using PythonNET Fails on festival charts if \r in end of lines Sep 10, 2024
@shacha086 shacha086 reopened this Sep 10, 2024
@shacha086
Copy link
Author

又排查了下,发现是换行符的问题
如果文件用\n换行就能正常使用,如果文件用\r\n换行就会报错
奇怪的是如果不是festival谱面,以\r\n换行的ma2也能正常转换为simai

@Neskol
Copy link
Owner

Neskol commented Sep 17, 2024

您好,之前我也注意到了这个问题,应该在master分支里有更新,请问您方便上传一个\r\n的样本吗?我这边确认一下

@Neskol Neskol self-assigned this Sep 17, 2024
@Neskol Neskol added the bug Something isn't working label Sep 17, 2024
@shacha086
Copy link
Author

您好,之前我也注意到了这个问题,应该在master分支里有更新,请问您方便上传一个\r\n的样本吗?我这边确认一下

https://raw.githubusercontent.com/shacha086/binaries/refs/heads/main/11474.ma2

@Neskol
Copy link
Owner

Neskol commented Dec 25, 2024

Screenshot 2024-12-25 at 13 45 17 这里并没有复现,可以正常编译

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants