Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeployedFlow.from_argo_workflows is incompatible with hyphen param names and apostrophes in param help #2349

Open
chrschorn opened this issue Mar 13, 2025 · 0 comments
Assignees

Comments

@chrschorn
Copy link

When using DeployedFlow.from_argo_workflows, some valid param configurations lead to errors. This seems to be because a "fake" flow file is constructed that will have invalid Python syntax:

  • param names with hyphens (e.g. dry-run) become dry-run = Parameter(...) which is invalid Python syntax
  • param help/descriptions with ' in them become dry_run = Parameter('dry_run', type=bool, help='Dry run, don't upload any results', required=False) which is also invalid (string is ended early by don't)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants