Skip to content

Commit 6d93f82

Browse files
committed
avoid adding domains to nginx config instead of resolving to loopback address
1 parent 5e079a4 commit 6d93f82

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

backend/internal/nginx.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,9 @@ const internalNginx = {
146146
if (ddnsResolver.ddnsRegex.test(address)) {
147147
const p = ddnsResolver.resolveAddress(address)
148148
.then((resolvedIP) => {
149-
Object.defineProperty(client, 'resolvedAddress', {value: resolvedIP});
149+
if (resolvedIP !== address) {
150+
Object.defineProperty(client, 'resolvedAddress', {value: resolvedIP});
151+
}
150152
return Promise.resolve();
151153
});
152154
promises.push(p);

backend/lib/ddns_resolver/ddns_resolver.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ const ddnsResolver = {
3434
.catch((/*error*/) => {
3535
// return input address in case of failure
3636
logger.error(`Failed to resolve IP for ${host}`);
37-
return '127.0.0.1'; // in case of failure, return the loopback address
37+
return domainName;
3838
});
3939
},
4040

0 commit comments

Comments
 (0)