Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class for person divs / image span #22

Open
ChrisRackauckas opened this issue Dec 21, 2016 · 0 comments
Open

Class for person divs / image span #22

ChrisRackauckas opened this issue Dec 21, 2016 · 0 comments

Comments

@ChrisRackauckas
Copy link
Member

One thing I noticed when reviewing Tao's latest PR is the following:

https://github.com/Tao2012/nielab.github.io/blob/adb3d6f436b547adda628b8d7cc1eb99704c9aaf/people/tao-peng.html#L23

That div is pretty specific: that setup should be implemented as a CSS class and then the div should just be set to that class. Instead of wrapping the image in a span and then setting the width, it should just be a class itself which sets the image left class and adds the width.

These are very non-essential though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant