Skip to content

ci: windows onedir and onefile tests don’t fail if they should #747

Description

@robin-nitrokey

We run a series of commands in cd-windows.yaml and expect that the step fails if any of the command fails:

run: |
dist/nitropy/nitropy.exe --help
dist/nitropy/nitropy.exe version
dist/nitropy/nitropy.exe nethsm --host nethsmdemo.nitrokey.com state
dist/nitropy/nitropy.exe list

But if the nethsm command fails, this step still succeeds, see for example:

https://github.com/Nitrokey/pynitrokey/actions/runs/23602605516/job/68736514345

Possible causes:

  • We don’t set the exit code correctly on Windows.
  • The Windows runner ignores the failure.

The same code works as expected on Linux:

run: |
dist/nitropy --help
dist/nitropy version
dist/nitropy nethsm --host nethsmdemo.nitrokey.com state
dist/nitropy list

https://github.com/Nitrokey/pynitrokey/actions/runs/23602605531/job/68736513097

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions