Request: Undo sample edits

[dpjpandone]

always wondered why sample edits were destructive. at least one layer of undo would be amazing. Great work btw. Thank you so much!

[prayerie]

Unfortunately it would require too much memory to put sample edits in the undo buffer. There could be a 1-layer undo shared between all samples, but I'm not sure how useful that'd be

[dpjpandone]

You're right about memory limitations. 1 layer global undo would be most useful, perform any function (enter note, truncate sample, cut/paste, etc.) state changes, previous state stored in memory until next state change.

[prayerie]

I think maybe the least disruptive system would be to have one layer of sample edit history in the undo buffer like this:

current state
^
|
previous audio for samp xyz <- UNDO
^
|
insert note action
^
|
insert note action 
...

But then if you edit another sample,

current state
^
|
previous audio for samp abc <- UNDO
^
|
(invalid)
^
|
insert note action
^
|
insert note action 
...

you would have to go through and remove/free the previous one. Which is doable, I suppose

The other alternative is a sample editor specific undo button, but it seems like maybe a bit of a waste of space/needlessly confusing