-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
new lints: path append is not path resolution #15985
Copy link
Copy link
Open
Labels
error-messagesConfusing messages and better diagnosticsConfusing messages and better diagnosticsfeatureFeature request or proposalFeature request or proposallanguageThe Nix expression language; parser, interpreter, primops, evaluation, etcThe Nix expression language; parser, interpreter, primops, evaluation, etc
Metadata
Metadata
Assignees
Labels
error-messagesConfusing messages and better diagnosticsConfusing messages and better diagnosticsfeatureFeature request or proposalFeature request or proposallanguageThe Nix expression language; parser, interpreter, primops, evaluation, etcThe Nix expression language; parser, interpreter, primops, evaluation, etc
Fields
Give feedbackNo fields configured for issues without a type.
Is your feature request related to a problem?
path + pathhas jank.Misunderstanding of path literals:
Simply objectionable:
Dubious pattern, but pretty sure this is in use, so this should be a separate flag:
Missing slash in string breaks path-level abstraction boundary:
Appended
"/.."is resolved without following symlink.This is probably ok most of the time, so consider
Should recommend
dirOfto make it actionable.Proposed solution
A set of new
lint-options that check for the above.Alternative solutions
Additional context
Checklist
Add 👍 to issues you find important.