Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failure: avro #317763

Closed
torgeirsh opened this issue Jun 6, 2024 · 4 comments
Closed

Build failure: avro #317763

torgeirsh opened this issue Jun 6, 2024 · 4 comments
Labels

Comments

@torgeirsh
Copy link
Contributor

Steps To Reproduce

The package is already marked broken.

Build log

https://hydra.nixos.org/build/245807960/nixlog/1

Additional context

The doctest dependency is constrained to < 0.21, but nixpkgs currently contains 0.22.2. Relaxing the constraint to < 0.23 seems to solve the problem, as the tests run and are green. Is that something that can be patched in nixpkgs, or is a hackage revision or upstream patch a better option?

Notify maintainers

Metadata

[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.8.0-35-generic, Ubuntu, 24.04 LTS (Noble Numbat), nobuild`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.1`
 - channels(root): `"nixpkgs"`

Add a 👍 reaction to issues you find important.

@torgeirsh torgeirsh added the 0.kind: build failure A package fails to build label Jun 6, 2024
@torgeirsh
Copy link
Contributor Author

I submitted a patch upstream: haskell-works/avro#195

@alexfmpe
Copy link
Member

Is that something that can be patched in nixpkgs, or is a hackage revision or upstream patch a better option?

I think the preference order is release > revision > fetchpatch > fix-in-nixpkgs (in this case, doJailbreak)

Thanks for the upstream fix - used it in #328772

@torgeirsh
Copy link
Contributor Author

Thanks! Once it's merged into the master branch, are additional steps needed to merge it into the release-24.05 branch?

@alexfmpe
Copy link
Member

Yop: https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#how-to-backport-pull-requests

@ghost ghost closed this as completed Dec 24, 2024
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants