chore: Fix clippy and etc

Author: Norbytus

crates/macros/src/interface.rs

@@ -49,14 +49,16 @@ struct InterfaceData<'a> {
 }
 
 impl ToTokens for InterfaceData<'_> {
+    #[allow(clippy::too_many_lines)]
     fn to_tokens(&self, tokens: &mut TokenStream) {
         let interface_name = format_ident!("PhpInterface{}", self.ident);
         let name = &self.name;
         let implements = &self.attrs.extends;
         let methods_sig = &self.methods;
         let constants = &self.constants;
 
-        let _constructor = self.constructor
+        let _constructor = self
+            .constructor
             .as_ref()
             .map(|func| func.constructor_meta(&self.path))
             .option_tokens();

src/builders/class.rs

@@ -58,6 +58,8 @@ impl ClassBuilder {
         }
     }
 
+    /// Return PHP class flags
+    #[must_use]
     pub fn get_flags(&self) -> u32 {
         self.ce.ce_flags
     }

src/describe/mod.rs

@@ -7,7 +7,7 @@ use crate::builders::EnumBuilder;
 use crate::{
     builders::{ClassBuilder, FunctionBuilder},
     constant::IntoConst,
-    flags::{ClassFlags, DataType, MethodFlags, PropertyFlags},
+    flags::{DataType, MethodFlags, PropertyFlags},
     prelude::ModuleBuilder,
 };
 use abi::{Option, RString, Str, Vec};
@@ -274,7 +274,7 @@ impl From<ClassBuilder> for Class {
                 .map(Constant::from)
                 .collect::<StdVec<_>>()
                 .into(),
-            flags: flags,
+            flags,
         }
     }
 }

src/describe/stub.rs

@@ -226,7 +226,7 @@ impl ToStub for Class {
         self.docs.fmt_stub(buf)?;
 
         let (_, name) = split_namespace(self.name.as_ref());
-        let flags = ClassFlags::from_bits(self.flags).unwrap();
+        let flags = ClassFlags::from_bits(self.flags).unwrap_or(ClassFlags::empty());
         let is_interface = flags.contains(ClassFlags::Interface);
 
         if is_interface {
@@ -379,10 +379,10 @@ impl ToStub for Method {
             }
         }
 
-        if !self.r#abstract {
-            writeln!(buf, " {{}}")
-        } else {
+        if self.r#abstract {
             writeln!(buf, ";")
+        } else {
+            writeln!(buf, " {{}}")
         }
     }
 }

tests/src/integration/interface/mod.rs

@@ -6,6 +6,7 @@ use ext_php_rs::zend::ce;
 #[php_interface]
 #[php(extends(ce = ce::throwable, stub = "\\Throwable"))]
 #[php(name = "ExtPhpRs\\Interface\\EmptyObjectInterface")]
+#[allow(dead_code)]
 pub trait EmptyObjectTrait {
     const STRING_CONST: &'static str = "STRING_CONST";