diff --git a/.github/workflows/auto-reviewers.yml b/.github/workflows/auto-reviewers.yml deleted file mode 100644 index b4aa751..0000000 --- a/.github/workflows/auto-reviewers.yml +++ /dev/null @@ -1,19 +0,0 @@ -name: AI Code Review -on: - pull_request: - types: [opened, synchronize] # triggers on new PR and each commit - -jobs: - ai-review: - runs-on: ubuntu-latest - steps: - - - name: Run AI Reviewer - uses: propstreet/reviewer@v2 - with: - azureOpenAIKey: ${{ secrets.AZURE_PR_AI_OPENAI_API_KEY }} - azureOpenAIEndpoint: ${{ secrets.AZURE_PR_AI_OPENAI_REASONING_ENDPOINT }} - azureOpenAIDeployment: ${{ secrets.AZURE_PR_AI_OPENAI_REASONING_DEPLOYMENT }} - azureOpenAIVersion: ${{ secrets.AZURE_PR_AI_OPENAI_REASONING_VERSION }} - env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} diff --git a/HzMemoryCache/Diagnostics/HzActivities.cs b/HzMemoryCache/Diagnostics/HzActivities.cs index 04c68bb..15e6827 100644 --- a/HzMemoryCache/Diagnostics/HzActivities.cs +++ b/HzMemoryCache/Diagnostics/HzActivities.cs @@ -10,22 +10,17 @@ public static class HzActivities public static class Names { - public const string SetRedis = "set to redis"; public const string Get = "get"; - public const string GetRedis = "get from redis"; public const string GetOrSetCacheMiss = "get or set on cache miss"; public const string GetOrSetBatch = "get or set batch"; - public const string GetBatchRedis = "get batch from redis"; public const string Remove = "remove"; public const string RemoveByPattern = "remove by pattern"; - public const string RemoveRedis = "remove from redis"; public const string RemoveByPatternRedis = "remove by pattern from redis"; public const string RemoveItem = "remove item"; public const string Clear = "clear"; public const string ExecuteFactory = "execute factory"; public const string NotifyItemChange = "notify item change"; - public const string Subscribe = "subscribe"; public const string ValueChanged = "value changed"; public const string EvictExpired = "evict expired"; public const string ProcessExpiredEviction = "process expired eviction"; diff --git a/RedisBackedHzCache/RedisBackedHzCache.cs b/RedisBackedHzCache/RedisBackedHzCache.cs index fa4d56f..3da1ba5 100644 --- a/RedisBackedHzCache/RedisBackedHzCache.cs +++ b/RedisBackedHzCache/RedisBackedHzCache.cs @@ -118,7 +118,6 @@ public RedisBackedHzCache(RedisBackedHzCacheOptions options) // Messages from other instances through redis. redis.GetSubscriber().Subscribe(options.applicationCachePrefix, (_, message) => { - using var activity = HzActivities.Source.StartActivityWithCommonTags(HzActivities.Names.Subscribe, HzActivities.Area.RedisBackedHzCache); var invalidationMessage = JsonSerializer.Deserialize(message.ToString()); if (invalidationMessage.applicationCachePrefix != options.applicationCachePrefix) { @@ -141,7 +140,6 @@ public RedisBackedHzCache(RedisBackedHzCacheOptions options) private void RedisRemove(string redisKey) { - using var activity = HzActivities.Source.StartActivityWithCommonTags(HzActivities.Names.RemoveRedis, HzActivities.Area.Redis, key: redisKey); redisDb.KeyDelete(redisKey); } @@ -153,9 +151,7 @@ private void RedisRemoveByPattern(string redisKey) private void RedisSet(string redisKey, byte[] objectData, TTLValue ttlValue) { - using var activity = HzActivities.Source.StartActivityWithCommonTags(HzActivities.Names.SetRedis, HzActivities.Area.Redis, key:redisKey); - redisDb.StringSet(redisKey, objectData, - TimeSpan.FromMilliseconds(ttlValue.absoluteExpireTime - DateTimeOffset.Now.ToUnixTimeMilliseconds())); + redisDb.StringSet(redisKey, objectData, TimeSpan.FromMilliseconds(ttlValue.absoluteExpireTime - DateTimeOffset.Now.ToUnixTimeMilliseconds())); } public void RemoveByPattern(string pattern, bool sendNotification = true) @@ -205,7 +201,6 @@ public T Get(string key) private RedisValue GetRedisValue(string key) { - using var activity = HzActivities.Source.StartActivityWithCommonTags(HzActivities.Names.GetRedis, HzActivities.Area.Redis, key: key); return redisDb.StringGet(GetRedisKey(key)); } @@ -277,8 +272,6 @@ public IList GetOrSetBatch(IList keys, Func, List(RedisKey[] redisKeyList) { - using var activity = HzActivities.Source.StartActivityWithCommonTags(HzActivities.Names.GetBatchRedis, HzActivities.Area.Redis); - return redisDb.StringGet(redisKeyList); } diff --git a/RedisBackedHzCache/RedisBackedHzCache.csproj b/RedisBackedHzCache/RedisBackedHzCache.csproj index 4bb9afd..0951ad3 100644 --- a/RedisBackedHzCache/RedisBackedHzCache.csproj +++ b/RedisBackedHzCache/RedisBackedHzCache.csproj @@ -18,7 +18,7 @@ - + diff --git a/RedisBackedHzCache/RedisBackedHzCacheAsync.cs b/RedisBackedHzCache/RedisBackedHzCacheAsync.cs index df01f56..880eff6 100644 --- a/RedisBackedHzCache/RedisBackedHzCacheAsync.cs +++ b/RedisBackedHzCache/RedisBackedHzCacheAsync.cs @@ -40,10 +40,9 @@ public async Task GetAsync(string key) return value; } - private async Task GetRedisValueAsync(string key) + private Task GetRedisValueAsync(string key) { - using var activity = HzActivities.Source.StartActivityWithCommonTags(HzActivities.Names.GetRedis, HzActivities.Area.RedisBackedHzCache, async: true, key: key); - return await redisDb.StringGetAsync(GetRedisKey(key)).ConfigureAwait(false); + return redisDb.StringGetAsync(GetRedisKey(key)); } public Task SetAsync(string key, T value) @@ -115,7 +114,6 @@ public async Task> GetOrSetBatchAsync(IList keys, Func RedisBatchResultAsync(RedisKey[] redisKeyList) { - using var activity = HzActivities.Source.StartActivityWithCommonTags(HzActivities.Names.GetBatchRedis, HzActivities.Area.Redis, async: true); return redisDb.StringGetAsync(redisKeyList); } diff --git a/RedisIDistributedCache/RedisIDistributedCache.csproj b/RedisIDistributedCache/RedisIDistributedCache.csproj index 6047397..0b99979 100644 --- a/RedisIDistributedCache/RedisIDistributedCache.csproj +++ b/RedisIDistributedCache/RedisIDistributedCache.csproj @@ -18,7 +18,7 @@ - +