Skip to content

[18.0] [MIG] account_move_line_payment #913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Shide wants to merge 3 commits into
base: 18.0
Choose a base branch
from
Open

[18.0] [MIG] account_move_line_payment #913

Shide wants to merge 3 commits into from
+941 −0

Conversation

@Shide
Copy link

@Shide Shide commented Dec 4, 2025

Straight forward migration.
Superseeds #892. Attended all suggestions.

MT-12596 @moduon @rafaelbn @Gelojr @pedrobaeza @RedaKarimi please review if you want 😄

@Shide Shide force-pushed the 18.0-mig-account_move_line_payment branch from c732d52 to dd62b9c Compare December 4, 2025 12:30
@Shide Shide mentioned this pull request Dec 4, 2025
Open
@mmircoli-nexapp
Copy link

mmircoli-nexapp commented Dec 4, 2025 •
edited
Loading

you have missed the history of the migration is wrong.
Please follow the the instruction for migration module

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-18.0

@Shide
Copy link
Author

Shide commented Dec 5, 2025

you have missed the history of the migration is wrong. Please follow the the instruction for migration module

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-18.0

I've followed the steps and the commit history is correct.
I've "fixup" translation commits

@mmircoli-nexapp
Copy link

mmircoli-nexapp commented Dec 5, 2025

you have missed the history of the migration is wrong. Please follow the the instruction for migration module
https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-18.0

I've followed the steps and the commit history is correct. I've "fixup" translation commits

ok I approved

@mmircoli-nexapp
Copy link

mmircoli-nexapp commented Dec 11, 2025

i think is ready to merge

@yajo
Copy link
Member

yajo commented Jan 21, 2026

I've "fixup" translation commits

FWIW the wiki explains that translation commits should not be squashed with the change commit. Instead, continuous translation commits should be squashed in a single translation commit.

So, when rebasing, this would be wrong:

pick 4c88180 (contributor1) [ADD] module_x
f 00d0e95 (translator1) Added translation using Weblate (Italian)
f e34ab12 (translator1) Translated using Weblate (Italian)
f 19891ab (translator1) Translated using Weblate (Italian)

But this would be correct:

pick 4c88180 (contributor1) [ADD] module_x
pick 00d0e95 (translator1) Added translation using Weblate (Italian)
f e34ab12 (translator1) Translated using Weblate (Italian)
f 19891ab (translator1) Translated using Weblate (Italian)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@yajo yajo yajo approved these changes

@mmircoli-nexapp mmircoli-nexapp mmircoli-nexapp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Shide @mmircoli-nexapp @yajo @OCA-git-bot