[16.0] account_payment_partner: Don't void the bank on account move if no payment mode

[rousseldenis]

If no payment mode is set on the account move, the partner bank is voided if already filled in.

https://github.com/OCA/bank-payment/pull/1094/files#diff-560b5e454acd270e25223d56b85967eaec36fe9a08eac999124990650aa32f6cR114

I think this assertion is true for computed fields not stored... :

Now that partner_bank_id is a computed field, we shouldn't set its value
to False if the move is not a vendor bill or doesn't have a payment mode.

So, I will do a fix for that

@grindtildeath

[rousseldenis]

This in order to fix incompatibility with overrides on bank computation on account moves:

https://github.com/OCA/account-invoicing/actions/runs/13049589264/job/36406666815?pr=1736#step:8:211

[jbaudoux]

It's the occasion to improve the tests to include the refunds:
move_type == "out_invoice"
should be
move_type in ("out_invoice", "in_refund")

same for the other direction

[rousseldenis]

@yvaucher

[grindtildeath]

@rousseldenis Answering here for your question on #1183 (comment)

It's been some time since I did #1094 but IIRC the idea was not to set partner_bank_id if we don't have a payment mode.

But I agree if it's set manually, then the computation shouldn't remove it.

[rousseldenis]

but IIRC the idea was not to set partner_bank_id if we don't have a payment mode.

The problem is some other modules that don't depend on this would fill in the field.

We can agree that we should not modify the field if no payment mode is not filled in.

[github-actions]

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.