-
-
Notifications
You must be signed in to change notification settings - Fork 192
[17.0] [MIG] l10n_eu_product_adr_dangerous_goods: migration to v17 #232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 17.0
Are you sure you want to change the base?
[17.0] [MIG] l10n_eu_product_adr_dangerous_goods: migration to v17 #232
Conversation
322e60f to
6683831
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
|
@pedrobaeza now that #231 is merged, could you reopen this? I’ll handle the remaining work to get it done. |
Currently translated at 100.0% (52 of 52 strings) Translation: community-data-files-14.0/community-data-files-14.0-l10n_eu_product_adr_dangerous_goods Translate-URL: https://translation.odoo-community.org/projects/community-data-files-14-0/community-data-files-14-0-l10n_eu_product_adr_dangerous_goods/es/
0088285 to
dce5931
Compare
|
@pedrobaeza wouldn’t it be better to remove the stale label as well, please? |
|
Tested on Odoo 17 CE — installs fine, “Is Dangerous” checkbox and Dangerous Goods tab work as expected. Only concern is the UX could be more friendly. When “Is Dangerous” is checked but no Dangerous Good name is entered, the error could be more specific or auto-open the Dangerous Goods tab. |
|
@AnsarLatif, thank you for pointing this out. To clarify for everyone, the components you mentioned are part of the l10n_eu_product_adr module's architecture. This addon relies on them but does not define them directly. |
edescalona
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Although commit history comes from v14 is really a backport from v18 merged addon.
#177
@BinhexTeam