Skip to content

Conversation

@rrebollo
Copy link

@rrebollo rrebollo commented Mar 15, 2025

Although commit history comes from v14 is really a backport from v18 merged addon.

#177
@BinhexTeam

@rrebollo rrebollo force-pushed the 17.0-mig-l10n_eu_product_adr_dangerous_goods branch from 322e60f to 6683831 Compare March 15, 2025 11:26
@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 13, 2025
@github-actions github-actions bot closed this Aug 17, 2025
@rrebollo
Copy link
Author

rrebollo commented Sep 1, 2025

@pedrobaeza now that #231 is merged, could you reopen this? I’ll handle the remaining work to get it done.

@pedrobaeza pedrobaeza reopened this Sep 1, 2025
@rrebollo rrebollo force-pushed the 17.0-mig-l10n_eu_product_adr_dangerous_goods branch from 0088285 to dce5931 Compare September 1, 2025 19:19
@rrebollo rrebollo marked this pull request as ready for review September 1, 2025 19:22
@rrebollo
Copy link
Author

rrebollo commented Sep 1, 2025

@pedrobaeza wouldn’t it be better to remove the stale label as well, please?

@pedrobaeza pedrobaeza removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 1, 2025
@AnsarLatif
Copy link

AnsarLatif commented Sep 7, 2025

Tested on Odoo 17 CE — installs fine, “Is Dangerous” checkbox and Dangerous Goods tab work as expected. Only concern is the UX could be more friendly. When “Is Dangerous” is checked but no Dangerous Good name is entered, the error could be more specific or auto-open the Dangerous Goods tab.

@rrebollo
Copy link
Author

@AnsarLatif, thank you for pointing this out. To clarify for everyone, the components you mentioned are part of the l10n_eu_product_adr module's architecture. This addon relies on them but does not define them directly.

Copy link

@edescalona edescalona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants