Skip to content

[18.0] [IMP] pydantic: moving from pydantic v1 to v2 #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
OCA-git-bot merged 3 commits into from
Jan 19, 2026
Merged

[18.0] [IMP] pydantic: moving from pydantic v1 to v2 #564

OCA-git-bot merged 3 commits into from
Jan 19, 2026

Conversation

@ThomasBinsfeld
Copy link
Contributor

@ThomasBinsfeld ThomasBinsfeld commented Sep 17, 2025

Forward port of #551

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Sep 17, 2025

Hi @lmignon,
some modules you are maintaining are being modified, check this out!

@ThomasBinsfeld ThomasBinsfeld force-pushed the 18.0-pydantic-support-v2 branch from 82481de to 3155cb2 Compare September 17, 2025 12:08
@ThomasBinsfeld
Copy link
Contributor Author

ThomasBinsfeld commented Sep 17, 2025

@petrus-v

@github-actions
Copy link

github-actions bot commented Jan 18, 2026

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 18, 2026
petrus-v
petrus-v approved these changes Jan 19, 2026
View reviewed changes
Copy link
Contributor

@petrus-v petrus-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for migration, changed commits code looks good to me 👍

@lmignon
Copy link
Contributor

lmignon commented Jan 19, 2026

@ThomasBinsfeld Can you rebase and fix the merge conflicts so we can proceed to the merge? Thank in advance.

@ThomasBinsfeld ThomasBinsfeld force-pushed the 18.0-pydantic-support-v2 branch from 72539fc to 4fb83e5 Compare January 19, 2026 09:27
@ThomasBinsfeld
Copy link
Contributor Author

ThomasBinsfeld commented Jan 19, 2026

@ThomasBinsfeld Can you rebase and fix the merge conflicts so we can proceed to the merge? Thank in advance.

Done

@lmignon
Copy link
Contributor

lmignon commented Jan 19, 2026

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Jan 19, 2026

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-564-by-lmignon-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 999ca24 into OCA:18.0 Jan 19, 2026
7 checks passed
@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Jan 19, 2026

Congratulations, your PR was merged at 3c7dfb2. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lmignon lmignon lmignon approved these changes

+1 more reviewer

@petrus-v petrus-v petrus-v approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉 stale PR/Issue without recent activity, it'll be soon closed automatically.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ThomasBinsfeld @OCA-git-bot @lmignon @petrus-v