[18.0][ADD] base_tier_validation_authentication_confirm #1213
+963
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArnauCForgeFlow
changed the title
ArnauCForgeFlow
force-pushed
the
18.0-add-base_tier_validation_password_confirm
branch
2 times, most recently
from
7c4c1f1 to
2cc208a
Compare
ArnauCForgeFlow
force-pushed
the
18.0-add-base_tier_validation_password_confirm
branch
from
2cc208a to
8777a22
Compare
ArnauCForgeFlow
changed the title
ArnauCForgeFlow
force-pushed
the
18.0-add-base_tier_validation_password_confirm
branch
from
8777a22 to
41d98d1
Compare
LoisRForgeFlow
approved these changes
Jan 21, 2026
Contributor
LoisRForgeFlow
left a comment
LoisRForgeFlow
left a comment
There was a problem hiding this comment.
LGTM, functional test and code review 👍
Contributor
|
@pedrobaeza @etobella What do you think? |
Member
|
From a technical perspective it look Ok, for testing it functionally, I need to do it from a local environment, I will check it |
pedrobaeza
reviewed
Jan 21, 2026
Member
pedrobaeza
left a comment
pedrobaeza
left a comment
There was a problem hiding this comment.
About the name, I would follow from left to right the process flow, and short it, so I would call it base_tier_validation_confirm_auth.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new module base_tier_validation_authentication_confirm that allows us setting an authentication confirmation during the tier validation process. The system will ask the user to authenticate himself in order to validate or reject the review. If the comment option is enabled, the password confirmation will be requested after the comment wizard.
Depends on -> #1217