[19.0][MIG] fs_attachment Migration 19.0

Author: cyrilmanuel

.pre-commit-config.yaml

@@ -1,7 +1,6 @@
 exclude: |
   (?x)
   # NOT INSTALLABLE ADDONS
-  ^fs_attachment/|
   ^fs_attachment_s3/|
   ^fs_file/|
   ^fs_folder/|

fs_attachment/__manifest__.py

@@ -5,7 +5,7 @@
 {
     "name": "Base Attachment Object Store",
     "summary": "Store attachments on external object store",
-    "version": "18.0.2.1.0",
+    "version": "19.0.1.0.0",
     "author": "Camptocamp, ACSONE SA/NV, Odoo Community Association (OCA)",
     "license": "AGPL-3",
     "development_status": "Beta",
@@ -17,7 +17,7 @@
         "views/fs_storage.xml",
     ],
     "external_dependencies": {"python": ["python_slugify", "fsspec>=2025.3.0"]},
-    "installable": False,
+    "installable": True,
     "auto_install": False,
     "maintainers": ["lmignon"],
     "pre_init_hook": "pre_init_hook",

fs_attachment/models/fs_file_gc.py

@@ -17,13 +17,10 @@ class FsFileGC(models.Model):
     store_fname = fields.Char("Stored Filename")
     fs_storage_code = fields.Char("Storage Code")
 
-    _sql_constraints = [
-        (
-            "store_fname_uniq",
-            "unique (store_fname)",
-            "The stored filename must be unique!",
-        ),
-    ]
+    _store_fname_uniq = models.Constraint(
+        "unique (store_fname)",
+        "The stored filename must be unique!",
+    )
 
     def _is_test_mode(self) -> bool:
         """Return True if we are running the tests, so we do not mark files for
@@ -101,7 +98,7 @@ def _gc_files(self) -> None:
         # the LOCK statement will wait until those concurrent transactions end.
         # But this transaction will not see the new attachements if it has done
         # other requests before the LOCK (like the method _storage() above).
-        cr = self._cr
+        cr = self.env.cr
         cr.commit()  # pylint: disable=invalid-commit
 
         # prevent all concurrent updates on ir_attachment and fs_file_gc
@@ -125,7 +122,7 @@ def _gc_files_unsafe(self) -> None:
         if not codes:
             return
         # we process by batch of storage codes.
-        self._cr.execute(
+        self.env.cr.execute(
             """
             SELECT
                 fs_storage_code,
@@ -145,7 +142,7 @@ def _gc_files_unsafe(self) -> None:
             """,
             (tuple(codes),),
         )
-        for code, store_fnames in self._cr.fetchall():
+        for code, store_fnames in self.env.cr.fetchall():
             self.env["fs.storage"].get_by_code(code)
             fs = self.env["fs.storage"].get_fs_by_code(code)
             for store_fname in store_fnames:
@@ -156,7 +153,7 @@ def _gc_files_unsafe(self) -> None:
                     _logger.debug("Failed to remove file %s", store_fname)
 
         # delete the records from the table fs_file_gc
-        self._cr.execute(
+        self.env.cr.execute(
             """
             DELETE FROM
                 fs_file_gc

fs_attachment/models/fs_storage.py

@@ -85,7 +85,7 @@ def _check_use_as_default_for_attachments(self):
         defaults = self.search([]).filtered("use_as_default_for_attachments")
         if len(defaults) > 1:
             raise ValidationError(
-                _("Only one storage can be used as default for attachments")
+                self.env._("Only one storage can be used as default for attachments")
             )
 
     @property
@@ -132,7 +132,7 @@ def write(self, vals):
             if not vals["use_as_default_for_attachments"]:
                 vals["force_db_for_default_attachment_rules"] = None
         res = super().write(vals)
-        self._create_write_check_constraints(vals)
+        self.env.create_write_check_constraints(vals)
         return res
 
     def _create_write_check_constraints(self, vals):
@@ -165,7 +165,7 @@ def _check_force_db_for_default_attachment_rules(self):
                 continue
             if not rec.use_as_default_for_attachments:
                 raise ValidationError(
-                    _(
+                    self.env._(
                         "The force_db_for_default_attachment_rules can only be set "
                         "if the storage is used as default for attachments."
                     )
@@ -174,7 +174,7 @@ def _check_force_db_for_default_attachment_rules(self):
                 const_eval(rec.force_db_for_default_attachment_rules)
             except (SyntaxError, TypeError, ValueError) as e:
                 raise ValidationError(
-                    _(
+                    self.env._(
                         "The force_db_for_default_attachment_rules is not a valid "
                         "python dict."
                     )

fs_attachment/models/ir_attachment.py

@@ -18,9 +18,9 @@
 from slugify import slugify  # pylint: disable=missing-manifest-dependency
 
 import odoo
-from odoo import _, api, fields, models
+from odoo import api, fields, models
 from odoo.exceptions import AccessError, UserError
-from odoo.osv.expression import AND, OR, normalize_domain
+from odoo.fields import Domain
 
 from .strtobool import strtobool
 
@@ -169,9 +169,9 @@ def _store_in_db_instead_of_object_storage_domain(self):
         for mimetype_key, limit in storage_config.items():
             part = [("mimetype", "=like", f"{mimetype_key}%")]
             if limit:
-                part = AND([part, [("file_size", "<=", limit)]])
+                part = Domain.AND([part, [("file_size", "<=", limit)]])
             # OR simplifies to [(1, '=', 1)] if a domain being OR'ed is empty
-            domain = OR([domain, part]) if domain else part
+            domain = Domain.OR([domain, part]) if domain else part
         return domain
 
     def _store_in_db_instead_of_object_storage(self, data, mimetype):
@@ -306,7 +306,7 @@ def write(self, vals):
                     vals["mimetype"] = mimetypes[0]
                 else:
                     raise UserError(
-                        _(
+                        self.env._(
                             "You can't write on multiple attachments with different "
                             "mimetypes at the same time."
                         )
@@ -723,7 +723,9 @@ def _move_attachment_to_store(self):
     @api.model
     def force_storage(self):
         if not self.env["res.users"].browse(self.env.uid)._is_admin():
-            raise AccessError(_("Only administrators can execute this action."))
+            raise AccessError(
+                self.env._("Only administrators can execute this action.")
+            )
         location = self.env.context.get("storage_location") or self._storage()
         if location not in self._get_storage_codes():
             return super().force_storage()
@@ -762,9 +764,9 @@ def force_storage_to_db_for_special_fields(
             )
             return
 
-        domain = AND(
+        domain = Domain.AND(
             (
-                normalize_domain(
+                Domain.normalize_domain(
                     [
                         ("store_fname", "=like", f"{storage}://%"),
                         # for res_field, see comment in
@@ -774,7 +776,9 @@ def force_storage_to_db_for_special_fields(
                         ("res_field", "!=", False),
                     ]
                 ),
-                normalize_domain(self._store_in_db_instead_of_object_storage_domain()),
+                Domain.normalize_domain(
+                    self._store_in_db_instead_of_object_storage_domain()
+                ),
             )
         )
 

fs_attachment/tests/test_fs_attachment.py

@@ -396,7 +396,7 @@ def test_create_attachments_basic_user(self):
         group_user = self.env.ref("base.group_user")
         group_partner_manager = self.env.ref("base.group_partner_manager")
         demo_user.write(
-            {"groups_id": [(6, 0, [group_user.id, group_partner_manager.id])]}
+            {"groups_ids": [(6, 0, [group_user.id, group_partner_manager.id])]}
         )
         # Create basic attachment
         self.ir_attachment_model.with_user(demo_user).create(

fs_attachment/tests/test_fs_attachment_file_like_adapter.py

@@ -16,7 +16,7 @@ def prepareClass(cls):
         cls.new_content = b"This is a new test attachment"
 
     def prepare(self):
-        self.attachment = self._create_attachment()
+        self.attachment = self.env.create_attachment()
 
     def open(self, attachment=None, mode="rb", new_version=False, **kwargs):
         return AttachmentFileLikeAdapter(

fs_attachment/tests/test_stream.py

@@ -170,7 +170,7 @@ def test_serving_field_image(self):
         demo_partner = self.env.ref("base.partner_demo")
         demo_partner.with_context(
             storage_location=self.temp_backend.code,
-        ).write({"image_128": base64.encodebytes(self._create_image(128, 128))})
+        ).write({"image_128": base64.encodebytes(self.env.create_image(128, 128))})
         url = f"/web/image/{demo_partner._name}/{demo_partner.id}/image_128"
         res = self.assertDownload(
             url,

requirements.txt

@@ -1,10 +1,3 @@
 # generated from manifests external_dependencies
-boto3
-fsspec>=2024.5.0
-fsspec>=2025.0.0
 fsspec>=2025.3.0
-fsspec[s3]
-msgraphfs
-paramiko
-pyftpdlib
 python_slugify