Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix buttons shortcode #117

Closed
robyngit opened this issue Oct 6, 2021 · 2 comments · Fixed by #126
Closed

Fix buttons shortcode #117

robyngit opened this issue Oct 6, 2021 · 2 comments · Fixed by #126
Assignees
Labels
bug Something isn't working templating

Comments

@robyngit
Copy link
Member

robyngit commented Oct 6, 2021

The buttons created in #102 look great! I noticed a couple of issues:

  1. some of the page references are not creating valid links. For example, in http://localhost:1313/goals/artisanal-fishing-opportunities/ the "practical guidance" button leads to a 404. I think this is because the location of the goal guidance pages changed. If we use hugo's ref function to resolve links, then these issues will be caught before the page is successfully built. It also allows content editors to link to pages with or without a file extension, with or without an anchor, and with or without the parent directory path (as long as the markdown file name is unique).

  2. Internal pages are opening in a new tab because of the taget="_blank" attribute added to all the links. This should be added conditionally based on whether the link starts with http.

I fixed these issues in the very similar button shortcode, see: ee425ad

@robyngit robyngit added bug Something isn't working templating labels Oct 6, 2021
@ThomasThelen ThomasThelen self-assigned this Oct 6, 2021
@ThomasThelen
Copy link
Member

Partially fixed 1 in 67bcf4c
Fixed 2 in 67eb159

If time permits I'll go through and use ref for the links

@robyngit robyngit self-assigned this Oct 14, 2021
@robyngit robyngit linked a pull request Oct 14, 2021 that will close this issue
robyngit added a commit that referenced this issue Oct 14, 2021
- Make header text fit on mobile screens
- Align breadcrumb with rest of navigation
- Consolidate similar buttons styles used throughout the website into one single 'button' class
- Consolidate button shortcodess. Delete buttons code, use two button codes instead.

Relates to #117, #28, #17, #103
@robyngit
Copy link
Member Author

Fixed this in #126 by formatting the button shortcode such that multiple buttons can be added in a row. Buttons shortcode no longer needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working templating
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants