You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The buttons created in #102 look great! I noticed a couple of issues:
some of the page references are not creating valid links. For example, in http://localhost:1313/goals/artisanal-fishing-opportunities/ the "practical guidance" button leads to a 404. I think this is because the location of the goal guidance pages changed. If we use hugo's ref function to resolve links, then these issues will be caught before the page is successfully built. It also allows content editors to link to pages with or without a file extension, with or without an anchor, and with or without the parent directory path (as long as the markdown file name is unique).
Internal pages are opening in a new tab because of the taget="_blank" attribute added to all the links. This should be added conditionally based on whether the link starts with http.
I fixed these issues in the very similar button shortcode, see: ee425ad
The text was updated successfully, but these errors were encountered:
- Make header text fit on mobile screens
- Align breadcrumb with rest of navigation
- Consolidate similar buttons styles used throughout the website into one single 'button' class
- Consolidate button shortcodess. Delete buttons code, use two button codes instead.
Relates to #117, #28, #17, #103
The buttons created in #102 look great! I noticed a couple of issues:
some of the page references are not creating valid links. For example, in
http://localhost:1313/goals/artisanal-fishing-opportunities/
the "practical guidance" button leads to a 404. I think this is because the location of the goal guidance pages changed. If we use hugo'sref
function to resolve links, then these issues will be caught before the page is successfully built. It also allows content editors to link to pages with or without a file extension, with or without an anchor, and with or without the parent directory path (as long as the markdown file name is unique).Internal pages are opening in a new tab because of the
taget="_blank"
attribute added to all the links. This should be added conditionally based on whether the link starts withhttp
.I fixed these issues in the very similar
button
shortcode, see: ee425adThe text was updated successfully, but these errors were encountered: