Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the colour variables defined in _variables.scss #29

Closed
robyngit opened this issue Jun 10, 2021 · 3 comments
Closed

Use the colour variables defined in _variables.scss #29

robyngit opened this issue Jun 10, 2021 · 3 comments

Comments

@robyngit
Copy link
Member

The _variables.scss file defines colours that are commonly used throughout the site. However, some .scss files (especially under /partials/) use the hard-coded hex colour code instead of the variable.

It's better to use variables rather than the colour hex-codes where possible (makes it easier if we want to change the colours one day.)

robyngit added a commit that referenced this issue Jun 23, 2021
- Use an <h> header tag for the header rather than a <li> list item
- Remove unnecessary html elements and classes
- Fix the header styles
- Convert some CSS colors to color variables

Relates to issue #29, #28
robyngit added a commit that referenced this issue Sep 1, 2021
Also add description to both SCSS files

Relates to #3 and #29
@ThomasThelen
Copy link
Member

A took a stab at this in 217e4ed . Note that some thing weren't changed. For example gradients

I went though all of the files except the ones in data-viz. I'm not sure if you want me mucking around in those styles, but I definitely wouldn't mind

@robyngit robyngit self-assigned this Oct 12, 2021
@robyngit robyngit linked a pull request Oct 12, 2021 that will close this issue
@robyngit
Copy link
Member Author

More progress made on this issue in #126, though there are still hex codes that should be switched to variables, and color variables that could probably be combined. Since everything works and looks good though, I think this issue should go on the back burner to be fixed if needed in the future.

@robyngit robyngit removed their assignment Oct 14, 2021
@robyngit robyngit removed a link to a pull request Oct 14, 2021
@ThomasThelen
Copy link
Member

Fixed in #136

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants