Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix full-width areas used within markdown content #93

Closed
robyngit opened this issue Sep 1, 2021 · 1 comment · Fixed by #126
Closed

Fix full-width areas used within markdown content #93

robyngit opened this issue Sep 1, 2021 · 1 comment · Fixed by #126
Assignees
@robyngit
Labels
bug Something isn't working templating

Comments

@robyngit
Copy link
Member

robyngit commented Sep 1, 2021

The changes made in PR #91 broke the divs that we had in the centre-column layout that were able to extend horizontally to take up the full width of the page. See the lines commented on here. The full-width divs were being used as containers for the global scores map and for tables generated from markdown. With the changes, these containers only take up the width of the center column.
@robyngit robyngit added bug Something isn't working templating labels Sep 1, 2021
@robyngit robyngit self-assigned this Oct 12, 2021
robyngit added a commit that referenced this issue Oct 12, 2021
@robyngit
Make the 3-col layout responsive + misc css fixes
e090249 
- Move left, right, center col styles to the layout style sheet since they use the same variables and styles are dependent on one another
- Fix the full-page container style used in the 3-col layout. Add a full-width container as well.
- Make the 3-col layout work on smaller screens
- Remove unused CSS styles
- Fix issue where the controls for the globe viz were overlapping the nav on mobile
- Style the right-side nav
- Tweak some misc styles

Relates to  #103, #17, #28, #67, #93
@robyngit robyngit linked a pull request Oct 12, 2021 that will close this issue
Style & layout improvements #126
Merged
@robyngit
Copy link
Member Author

Fixed in #126

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robyngit robyngit

Labels
bug Something isn't working templating
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Style & layout improvements OHI-Science/OHI-website
1 participant
@robyngit