Fixed the known clients logged in redis as anonymous, added slack message for DB sync.

Author: Camelia-Orcid

orcid-pub-web/src/main/java/org/orcid/api/filters/ApiRateLimitFilter.java

@@ -199,7 +199,7 @@ private void rateLimitClientRequest(String clientId, LocalDate today) throws JSO
         } else {
             dailyLimitsObj = new JSONObject();
             dailyLimitsObj.put(PapiRateLimitRedisClient.KEY_DATE_CREATED, System.currentTimeMillis());
-            dailyLimitsObj.put(PapiRateLimitRedisClient.KEY_IS_ANONYMOUS, true);
+            dailyLimitsObj.put(PapiRateLimitRedisClient.KEY_IS_ANONYMOUS, false);
             dailyLimitsObj.put(PapiRateLimitRedisClient.KEY_REQUEST_DATE, today.toString());
         }
         dailyLimitsObj.put(PapiRateLimitRedisClient.KEY_REQUEST_CLIENT, clientId);

orcid-scheduler-web/src/main/java/org/orcid/scheduler/report/PapiDailyLimitReport.java

@@ -75,22 +75,24 @@ public void papiDailyLimitReport() {
         if (enableRateLimiting) {
             try
             {
-            LocalDate yesterday = LocalDate.now().minusDays(1);
-            // save redis cached data to DB
-            papiRedisClient.saveRedisPapiLimitDateToDB(yesterday);
-            
-            //Report to Slack Channel
-            String mode = Features.ENABLE_PAPI_RATE_LIMITING.isActive() ? "ENFORCEMENT" : "MONITORING";
-            String SLACK_INTRO_MSG = "Public API Rate limit report - Date: " + yesterday.toString() + "\nCurrent Anonymous Requests Limit: " + anonymousRequestLimit
-                    + "\nCurrent Public API Clients Limit: " + knownRequestLimit + "\nMode: " + mode;
-            LOG .info(SLACK_INTRO_MSG);
-            slackManager.sendAlert(SLACK_INTRO_MSG, slackChannel, webhookUrl, webhookUrl);
-            
-            String SLACK_STATS_MSG = "Count of Anonymous IPs blocked: " + papiRateLimitingDao.countAnonymousRequestsWithLimitExceeded(yesterday, anonymousRequestLimit)
-                    + "\nCount of Public API clients that have exceeded the limit: "
-                    + papiRateLimitingDao.countClientRequestsWithLimitExceeded(yesterday, knownRequestLimit);           
-            LOG .info(SLACK_STATS_MSG);
-            slackManager.sendAlert(SLACK_STATS_MSG, slackChannel, webhookUrl, webhookUrl);
+                LocalDate yesterday = LocalDate.now().minusDays(1);
+                // save redis cached data to DB
+                papiRedisClient.saveRedisPapiLimitDateToDB(yesterday);
+                String SLACK_SAVE_DB_MSG = "Public API Rate DB Sync - Date: " + yesterday.toString() + ". Redis entries synched in Postgres." ;
+                LOG .info(SLACK_SAVE_DB_MSG);
+                slackManager.sendAlert(SLACK_SAVE_DB_MSG, slackChannel, webhookUrl, webhookUrl);
+                //Report to Slack Channel
+                String mode = Features.ENABLE_PAPI_RATE_LIMITING.isActive() ? "ENFORCEMENT" : "MONITORING";
+                String SLACK_INTRO_MSG = "Public API Rate limit report - Date: " + yesterday.toString() + "\nCurrent Anonymous Requests Limit: " + anonymousRequestLimit
+                        + "\nCurrent Public API Clients Limit: " + knownRequestLimit + "\nMode: " + mode;
+                LOG .info(SLACK_INTRO_MSG);
+                slackManager.sendAlert(SLACK_INTRO_MSG, slackChannel, webhookUrl, webhookUrl);
+                
+                String SLACK_STATS_MSG = "Count of Anonymous IPs blocked: " + papiRateLimitingDao.countAnonymousRequestsWithLimitExceeded(yesterday, anonymousRequestLimit)
+                        + "\nCount of Public API clients that have exceeded the limit: "
+                        + papiRateLimitingDao.countClientRequestsWithLimitExceeded(yesterday, knownRequestLimit);           
+                LOG .info(SLACK_STATS_MSG);
+                slackManager.sendAlert(SLACK_STATS_MSG, slackChannel, webhookUrl, webhookUrl);
             }
             catch (Exception ex) {
                 slackManager.sendAlert("!!!!! Exception when storing papi limit redis data to DB. Check the logs" + "\n" + ex.toString() , slackChannel, webhookUrl, webhookUrl);