-
Notifications
You must be signed in to change notification settings - Fork 16
refactor: only print subset of user properties. #1804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRefactors the user update route logging so that only a selected subset of non-sensitive user fields is included in the log metadata instead of the full updated user object. Sequence diagram for updated user update route loggingsequenceDiagram
actor Client
participant UserRouter
participant Database
participant Logger
Client->>UserRouter: GET /update
UserRouter->>Database: _executeTransaction(update user)
Database-->>UserRouter: user.new (updated user)
UserRouter->>UserRouter: delete sensitive fields from user.new
UserRouter->>UserRouter: build extra_log_info
UserRouter-->>Client: 200 OK with result [user.new]
UserRouter->>Logger: logRequestSuccess(extra_log_info)
Note over UserRouter,Logger: On error path
Client->>UserRouter: GET /update
UserRouter->>Database: _executeTransaction(update user)
Database--xUserRouter: error
UserRouter->>UserRouter: extra_log_info may be null or partial
UserRouter->>Logger: logRequestFailure(extra_log_info, error)
UserRouter->>Client: error response
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Enhancements: