Skip to content

Commit 26650f7

Browse files
committed
Cleanup
1 parent fe07841 commit 26650f7

File tree

5 files changed

+15
-12
lines changed

5 files changed

+15
-12
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,9 @@ before starting to add changes. Use example [placed in the end of the page](#exa
1111

1212
## [Unreleased]
1313

14+
- Updated `os2web/os2web_audit` version
15+
- Updated `os2web/os2web_datalookup` version
16+
1417
## [3.16.2] 2024-10-31
1518

1619
- Applied coding standards

modules/os2forms_digital_post/src/Helper/DigitalPostHelper.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@
88
use Drupal\os2web_datalookup\LookupResult\CompanyLookupResult;
99
use Drupal\os2web_datalookup\LookupResult\CprLookupResult;
1010
use Drupal\os2web_datalookup\Plugin\DataLookupManager;
11-
use Drupal\os2web_datalookup\Plugin\os2web\DataLookup\DataLookupInterfaceCompany;
12-
use Drupal\os2web_datalookup\Plugin\os2web\DataLookup\DataLookupInterfaceCpr;
11+
use Drupal\os2web_datalookup\Plugin\os2web\DataLookup\DataLookupCompanyInterface;
12+
use Drupal\os2web_datalookup\Plugin\os2web\DataLookup\DataLookupCprInterface;
1313
use Drupal\webform\WebformSubmissionInterface;
1414
use ItkDev\Serviceplatformen\Service\SF1601\SF1601;
1515
use ItkDev\Serviceplatformen\Service\SF1601\Serializer;
@@ -99,7 +99,7 @@ public function log($level, $message, array $context = []): void {
9999
*/
100100
public function lookupCpr(string $cpr): CprLookupResult {
101101
$instance = $this->dataLookupManager->createDefaultInstanceByGroup('cpr_lookup');
102-
if (!($instance instanceof DataLookupInterfaceCpr)) {
102+
if (!($instance instanceof DataLookupCprInterface)) {
103103
throw new RuntimeException('Cannot get CPR data lookup instance');
104104
}
105105
$lookupResult = $instance->lookup($cpr);
@@ -115,7 +115,7 @@ public function lookupCpr(string $cpr): CprLookupResult {
115115
*/
116116
public function lookupCvr(string $cvr): CompanyLookupResult {
117117
$instance = $this->dataLookupManager->createDefaultInstanceByGroup('cvr_lookup');
118-
if (!($instance instanceof DataLookupInterfaceCompany)) {
118+
if (!($instance instanceof DataLookupCompanyInterface)) {
119119
throw new RuntimeException('Cannot get CVR data lookup instance');
120120
}
121121
$lookupResult = $instance->lookup($cvr);

modules/os2forms_digital_post/src/Helper/WebformHelperSF1601.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@
1414
use Drupal\os2forms_digital_post\Plugin\AdvancedQueue\JobType\SendDigitalPostSF1601;
1515
use Drupal\os2forms_digital_post\Plugin\WebformHandler\WebformHandlerSF1601;
1616
use Drupal\os2web_datalookup\Plugin\DataLookupManager;
17-
use Drupal\os2web_datalookup\Plugin\os2web\DataLookup\DataLookupInterfaceCompany;
18-
use Drupal\os2web_datalookup\Plugin\os2web\DataLookup\DataLookupInterfaceCpr;
17+
use Drupal\os2web_datalookup\Plugin\os2web\DataLookup\DataLookupCompanyInterface;
18+
use Drupal\os2web_datalookup\Plugin\os2web\DataLookup\DataLookupCprInterface;
1919
use Drupal\webform\WebformSubmissionInterface;
2020
use Drupal\webform\WebformSubmissionStorageInterface;
2121
use ItkDev\Serviceplatformen\Service\SF1601\SF1601;
@@ -127,7 +127,7 @@ public function sendDigitalPost(WebformSubmissionInterface $submission, array $h
127127

128128
if (preg_match('/^\d{8}$/', $recipientIdentifier)) {
129129
$instance = $this->dataLookupManager->createDefaultInstanceByGroup('cvr_lookup');
130-
if (!($instance instanceof DataLookupInterfaceCompany)) {
130+
if (!($instance instanceof DataLookupCompanyInterface)) {
131131
throw new RuntimeException('Cannot get CVR data lookup instance');
132132
}
133133
$lookupResult = $instance->lookup($recipientIdentifier);
@@ -138,7 +138,7 @@ public function sendDigitalPost(WebformSubmissionInterface $submission, array $h
138138
}
139139
else {
140140
$instance = $this->dataLookupManager->createDefaultInstanceByGroup('cpr_lookup');
141-
if (!($instance instanceof DataLookupInterfaceCpr)) {
141+
if (!($instance instanceof DataLookupCprInterface)) {
142142
throw new RuntimeException('Cannot get CPR data lookup instance');
143143
}
144144
$lookupResult = $instance->lookup($recipientIdentifier);

modules/os2forms_nemid/src/Element/MitidChildrenSelectAjaxBehaviour.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ public static function mitidChildrenSelectAjax(array &$form, FormStateInterface
3939
/** @var \Drupal\os2web_datalookup\Plugin\DataLookupManager $os2web_datalookup_plugins */
4040
$os2web_datalookup_plugins = \Drupal::service('plugin.manager.os2web_datalookup');
4141

42-
/** @var \Drupal\os2web_datalookup\Plugin\os2web\DataLookup\DataLookupInterfaceCpr $cprPlugin */
42+
/** @var \Drupal\os2web_datalookup\Plugin\os2web\DataLookup\DataLookupCprInterface $cprPlugin */
4343
$cprPlugin = $os2web_datalookup_plugins->createDefaultInstanceByGroup('cpr_lookup');
4444

4545
if ($cprPlugin->isReady()) {

modules/os2forms_nemid/src/Service/FormsHelper.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,7 @@ public function lookupPersonData(FormStateInterface $form_state) {
182182
}
183183

184184
if ($cpr) {
185-
/** @var \Drupal\os2web_datalookup\Plugin\os2web\DataLookup\DataLookupInterfaceCpr $cprPlugin */
185+
/** @var \Drupal\os2web_datalookup\Plugin\os2web\DataLookup\DataLookupCprInterface $cprPlugin */
186186
$cprPlugin = $this->dataLookManager->createDefaultInstanceByGroup('cpr_lookup');
187187

188188
if ($cprPlugin->isReady()) {
@@ -284,15 +284,15 @@ private function lookupCompanyData(FormStateInterface $form_state) {
284284

285285
// Performing the lookup.
286286
if ($cvr) {
287-
/** @var \Drupal\os2web_datalookup\Plugin\os2web\DataLookup\DataLookupInterfaceCompany $cvrPlugin */
287+
/** @var \Drupal\os2web_datalookup\Plugin\os2web\DataLookup\DataLookupCompanyInterface $cvrPlugin */
288288
$cvrPlugin = $this->dataLookManager->createDefaultInstanceByGroup('cvr_lookup');
289289

290290
if ($cvrPlugin->isReady()) {
291291
$companyResult = $cvrPlugin->lookup($cvr);
292292
}
293293
}
294294
elseif ($pNumber) {
295-
/** @var \Drupal\os2web_datalookup\Plugin\os2web\DataLookup\DataLookupInterfaceCompany $pNumberPlugin */
295+
/** @var \Drupal\os2web_datalookup\Plugin\os2web\DataLookup\DataLookupCompanyInterface $pNumberPlugin */
296296
$pNumberPlugin = $this->dataLookManager->createDefaultInstanceByGroup('pnumber_lookup');
297297

298298
if ($pNumberPlugin->isReady()) {

0 commit comments

Comments
 (0)