Feat/safe module #107
Feat/safe module #107
Conversation
samparsky
force-pushed
the
feat/safe-module
branch
from
fb11745 to
a6bb0da
Compare
OisinKyne
left a comment
OisinKyne
left a comment
There was a problem hiding this comment.
Want to understand whether this can break if the amount of contribution addresses goes beyond a transfer()s gas mainly
| depositContract = IETH2DepositContract(eth2DepositContract); | ||
| } | ||
|
|
||
| receive() external payable { |
There was a problem hiding this comment.
Should we calculate at how many contributors might this break with 2100 gas, because the free gas in a receive is lower than the allocation of a new storage slot to write down their contribution?
We don't have to worry about fallback() when receive() is set, yes?
There was a problem hiding this comment.
not we don't have to worry about fallback()
There was a problem hiding this comment.
The 2100 gas limit doesn't hold here. Any interaction via transfer/send will revert with OOG
| handler.ghost_depositSum() - mockDepositContract.ghost_depositSum() - handler.ghost_rageQuitSum() | ||
| ); | ||
| } | ||
| } |
There was a problem hiding this comment.
I don't really understand this testing much, walk me through it on our next one on one call :)
Fixes #91