Remove garbage characters in the terminal (#999)

Author: AlexJerabek

config/helpers.ts

@@ -3,7 +3,6 @@ import * as fs from 'fs';
 import * as os from 'os';
 import chalk from 'chalk';
 import * as jsyaml from 'js-yaml';
-import { console } from './status';
 import { rimraf } from 'rimraf';
 import { isObject, isNil, isString, isEmpty } from 'lodash';
 

config/status.ts

@@ -1,6 +1,5 @@
-import * as nodeStatus from 'node-status';
 import chalk from 'chalk';
-import { isString, find, isNil, isArray } from 'lodash';
+import { isString, isNil, isArray } from 'lodash';
 
 interface IStage {
     steps: any[];
@@ -13,16 +12,29 @@ export class Status {
     steps: { [step: string]: boolean } = {};
 
     get console() {
-        return nodeStatus.console();
+        // Return the global console object methods
+        return {
+            log: global.console.log.bind(global.console),
+            error: global.console.error.bind(global.console),
+            warn: global.console.warn.bind(global.console),
+            info: global.console.info.bind(global.console)
+        };
     }
 
     constructor() {
-        /* Initialize the status library */
-        this.stages = nodeStatus.addItem('stages', {
-            steps: []
-        });
+        /* Initialize the simple status system */
+        this.stages = {
+            steps: [],
+            count: 0,
+            doneStep: this.doneStep.bind(this)
+        };
+    }
 
-        nodeStatus.start();
+    private doneStep(completed: boolean, message?: string): void {
+        const symbol = completed ? chalk.green('✓') : chalk.red('✗');
+        if (message) {
+            global.console.log(`${symbol} ${message}`);
+        }
     }
 
     /**
@@ -37,22 +49,18 @@ export class Status {
         success = success && additionalDetails.findIndex(item => item instanceof Error) < 0;
 
         const messageArray = getDetailsArray();
+        const symbol = success ? chalk.green('✓') : chalk.red('✗');
 
-        if (messageArray.length === 0) {
-            this.stages.doneStep(success);
-        } else {
-            // Add a newline before
-            messageArray.splice(0, 0, '');
-            this.stages.doneStep(success, messageArray.join('\n    * ') + '\n');
-            //FIXME `${chalk.bold.red('WARNING: one of the messages above was an error')}`)
-        }
-
-        this.steps[stage] = false;
+        // Log the completion with symbol
+        global.console.log(`${symbol} ${stage}`);
 
-        if (!find(this.steps as any, (item) => item === true)) {
-            nodeStatus.stop();
+        if (messageArray.length > 0) {
+            messageArray.forEach(msg => {
+                global.console.log(`    * ${msg}`);
+            });
         }
 
+        this.steps[stage] = false;
 
         // Helper:
         function getDetailsArray() {
@@ -82,12 +90,13 @@ export class Status {
     }
 
     /**
-     * Add a new stage and complete the previous stage.
+     * Add a new stage and mark it as started.
      * @param stage Name of the stage.
      */
     add(stage: string) {
         this.stages.steps.push(stage);
         this.steps[stage] = true;
+        global.console.log(chalk.cyan(`○ ${stage}`));
     }
 }
 

package.json

@@ -29,7 +29,6 @@
     "fs-extra": "11.3.2",
     "js-yaml": "^4.1.0",
     "lodash": "^4.17.21",
-    "node-status": "^1.0.0",
     "rimraf": "^6.0.1",
     "shelljs": "^0.10.0"
   },