Address PR review nits: drop dead printGlobResults, enforce lint

Two small fixes from the code review:

1. printGlobResults gulpfile helper called globby.sync(...), but globby
   dropped the .sync property in 14.x (we ship 16.2). The function had
   no callers — debug-only and silently broken. Deleted. With it gone,
   the only direct use of globby is removed, so the direct dep is
   pruned too (del still pulls its own nested globby@14, untouched).

2. The lint task previously called done() unconditionally, swallowing
   eslint's non-zero exit code "to match legacy gulp-tslint behavior."
   That was a sensible default while the rule set was inherited and
   undisciplined; now that the rule set is curated in this PR and the
   codebase is lint-clean, propagate the exit code so a future lint
   regression actually fails the build (and CI). Same pattern the
   tsc task uses.

Verified: npm run build still clean (0 lint errors, 8.5s end-to-end),
npm audit still 0.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: wikirby

gulpfile.js

@@ -6,7 +6,6 @@ var argv = require("yargs/yargs")(process.argv.slice(2)).argv;
 var concat = require("gulp-concat");
 var del = require("del").deleteAsync;
 var esbuild = require("esbuild");
-var globby = require("globby");
 var gulp = require("gulp");
 var less = require("gulp-less");
 var mergeJSON = require("gulp-merge-json");
@@ -42,13 +41,6 @@ var PATHS = {
 
 var ARIA_LIB_VERSION = "2.8.2";
 
-// Used for debugging glob declarations
-function printGlobResults(glob) {
-    globby.sync(glob).map(function(filePath) {
-        console.log(filePath);
-    });
-}
-
 function fileExists(path) {
     try { return fs.statSync(path).isFile(); } catch (e) { return false; }
 }
@@ -155,9 +147,8 @@ gulp.task("lint", function (done) {
     var eslintPkgDir = path.dirname(require.resolve("eslint/package.json"));
     var eslintBin = path.join(eslintPkgDir, "bin", "eslint.js");
     var eslint = spawn(process.execPath, [eslintBin, "--no-error-on-unmatched-pattern", "src/**/*.ts", "src/**/*.tsx"], { stdio: "inherit" });
-    eslint.on("close", function () {
-        // Match legacy gulp-tslint behavior: report findings but don't fail the build.
-        done();
+    eslint.on("close", function (code) {
+        done(code === 0 ? null : new Error("eslint exited with code " + code));
     });
 });
 

package-lock.json

@@ -28,7 +28,6 @@
         "esbuild": "0.28.0",
         "eslint": "10.4.0",
         "file-exists": "5.0.1",
-        "globby": "16.2.0",
         "gulp": "5.0.1",
         "gulp-concat": "2.6.1",
         "gulp-less": "5.0.0",