Better fixup CubeMetadata.__repr__ for the empty case too

ref Open-EO/openeo-python-driver#428

Author: soxofaan

openeo/_version.py

@@ -1 +1 @@
-__version__ = "0.46.0a1"
+__version__ = "0.46.0a2"

openeo/metadata.py

@@ -290,8 +290,10 @@ def __eq__(self, o: Any) -> bool:
     def __repr__(self) -> str:
         if self.has_band_dimension():
             return f"{self.__class__.__name__}(dimension_names={self.dimension_names()}, band_names={self.band_names})"
-        else:
+        elif self._dimensions is not None:
             return f"{self.__class__.__name__}(dimension_names={self.dimension_names()})"
+        else:
+            return f"{self.__class__.__name__}(dimensions=None)"
 
     def __str__(self) -> str:
         bands = self.band_names if self.has_band_dimension() else "no bands dimension"
@@ -304,10 +306,10 @@ def _clone_and_update(self, dimensions: Optional[List[Dimension]] = None, **kwar
             dimensions = self._dimensions
         return cls(dimensions=dimensions, **kwargs)
 
-    def dimension_names(self) -> List[str]:
+    def dimension_names(self) -> Union[List[str], None]:
         if self._dimensions is None:
             # TODO: better solution for unknown dimensions?
-            return ["unknown"]
+            return None
         return list(d.name for d in self._dimensions)
 
     def assert_valid_dimension(self, dimension: str) -> str:

tests/test_metadata.py

@@ -1211,7 +1211,7 @@ def test_metadata_resample_cube_spatial_preserve_non_spatial():
 
 def test_cube_metadata_repr_empty():
     metadata = CubeMetadata()
-    assert repr(metadata) == "CubeMetadata(dimension_names=['unknown'])"
+    assert repr(metadata) == "CubeMetadata(dimensions=None)"
 
 
 def test_cube_metadata_repr_with_bands():