#71 #114 #268 added TODO notes on deprecation of GeometryCollection

Author: soxofaan

openeo_driver/ProcessGraphDeserializer.py

@@ -1275,6 +1275,7 @@ def filter_spatial(args: Dict, env: EvalEnv) -> DriverDataCube:
         )
 
     if isinstance(geometries, dict):
+        # TODO #71 #114 #268 EP-3981 avoid GeometryCollection and standardize on vector cubes
         geometries = geojson_to_geometry(geometries)
         if isinstance(geometries, GeometryCollection):
             polygons = [

openeo_driver/datacube.py

@@ -578,6 +578,9 @@ def write_assets(
                 return {p.name: {"href": p} for p in components}
 
     def to_multipolygon(self) -> shapely.geometry.MultiPolygon:
+        # TODO: be more strict about point handling: current implementation:
+        #       if all items are points, a MultiPoint will be returned
+        #       if it is a mix of points and polygons, it will return a (Multi)Polygon, ignoring the points.
         return shapely.ops.unary_union(self._geometries.geometry)
 
     def to_legacy_save_result(self) -> Union["AggregatePolygonResult", "JSONResult"]:

openeo_driver/util/geometry.py

@@ -140,7 +140,8 @@ def _validate_feature_collection(geojson):
 
 def geojson_to_geometry(geojson: dict) -> BaseGeometry:
     """Convert GeoJSON object to shapely geometry object"""
-    # TODO #71 #114 EP-3981 standardize on using (FeatureCollection like) vector cubes  instead of GeometryCollection?
+    # TODO #71 #114 EP-3981 standardize on vector cubes instead of deprecated GeometryCollection?
+    _log.warning("geojson_to_geometry usage is deprecated and should be replaced by proper vector cube usage")
     validate_geojson_coordinates(geojson)
     if geojson["type"] == "FeatureCollection":
         geojson = {