Harden extract_default_job_options_from_process_graph

related to #366 and Open-EO/openeo-aggregator#173

Author: soxofaan

openeo_driver/_version.py

@@ -1 +1 @@
-__version__ = "0.126.0a1"
+__version__ = "0.126.1a1"

openeo_driver/processgraph.py

@@ -4,7 +4,7 @@
 
 import requests
 
-from openeo_driver.errors import OpenEOApiException
+from openeo_driver.errors import OpenEOApiException, ProcessGraphInvalidException
 from openeo_driver.util.http import is_http_url
 
 _log = logging.getLogger(__name__)
@@ -142,6 +142,8 @@ def extract_default_job_options_from_process_graph(
 
     job_options = []
     for node in process_graph.values():
+        if not (isinstance(node, dict) and "process_id" in node and "arguments" in node):
+            raise ProcessGraphInvalidException
         namespace = node.get("namespace")
         process_id = node["process_id"]
         if is_http_url(namespace):

tests/test_processgraph.py

@@ -1,4 +1,4 @@
-from openeo_driver.errors import OpenEOApiException
+from openeo_driver.errors import OpenEOApiException, ProcessGraphInvalidException
 from openeo_driver.processgraph import (
     get_process_definition_from_url,
     extract_default_job_options_from_process_graph,
@@ -99,3 +99,15 @@ def test_extract_default_job_options_from_process_graph(requests_mock):
     assert extract_default_job_options_from_process_graph(pg, processing_mode="synchronous") == {
         "cpu": "green",
     }
+
+
+@pytest.mark.parametrize(
+    "pg",
+    [
+        {"garbage": "yez"},
+        {"almost": {"procezz_id": "add", "arguments": {"x": "nope"}}},
+    ],
+)
+def test_extract_default_job_options_from_process_graph_garbage(pg):
+    with pytest.raises(ProcessGraphInvalidException):
+        extract_default_job_options_from_process_graph(ProcessGraphFlatDict(pg))