Extend /docx downloads to /file for arbitrary file types - #304
Open
drewmiller wants to merge 2 commits into
Open
Extend /docx downloads to /file for arbitrary file types#304drewmiller wants to merge 2 commits into
/docx downloads to /file for arbitrary file types#304drewmiller wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This extends the existing
/docxendpoint to allow for download of arbitrary files, not just DOCX. It consolidates the old/docxendpoint with a new/fileendpoint and redirects the former there.It's just a suggestion to allow other folks to extend it as we have.
Why / Motivation
Folks implementing in-browser editors and document viewers for the miscellaneous supported formats will want access to the raw file bytes as opposed to the results supplied by
/display.Changes
As above.
Tradeoffs & risks
The very minor trade-off is that folks who want to avoid the imperceptible redirect from
/docxto/filewill need to migrate. Then the/docxendpoint could be deprecated in favor of the more general/file.How verified
We ran the test suite, which was unaffected by the changes.
Checklist
git diffand removed unrelated changes..envfiles committed.