Skip to content

Review/refactor account-gui Verification.svelte for less translation bugs #1131

@Liemine

Description

@Liemine

Summary

We get a lot of translation bugs in the account-gui Verification.svelte, so we need to review this file and maybe refactor it. The translations are based on a query param in the URL. This is tricky, and translations can possibly fail if query param values change. This logic is in Stepup.svelte: Stepup.svelte -> explanation = decodeURIComponent(urlSearchParams.get("explanation"));

Acceptance criteria:

  • Check if we can remove the capitalizeForLocalizationsFile function
  • Check if the {#if verified} blok is needed or can be merged with the conditions block.
  • Why is the StepUpExplanation.Info.COPY empty and is it needed?
  • Check if this logic in Stepup.svelteis future proof we have 9 of them see ACR.java
    explanation = decodeURIComponent(urlSearchParams.get("explanation")); isExternalNameValidation = explanation === "validate_names_external"; isLinkedInstitutionRequired = explanation === "linked_institution";

Extra info:

None

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    Projects

    Status

    Backlog

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions