ErrorDecoder not invoked when Apache Http client throws checked exception

[tszlek-equinix]

Hi, I have discovered issue when using feign.httpclient.ApacheHttpClient.
In some cases Apache client throws ProtocolException which is a checked exception. This happens for example when server returned 303 HTTP code but there was no location header.
In such case Feign proxy throws UndeclaredThrowableException instead of invoking ErrorDecoder.

[gitaroktato]

@kdavisk6 Hi, 👋 can I give it a try in the scope of Hacktoberfest? Could you assign it to me?

[velo]

Absolutely @gitaroktato go for it

[gitaroktato]

@kdavisk6 I have two alternatives for solving the issue:

• https://github.com/gitaroktato/feign/commit/868e2a150f0911bb074d9071a88fadb210c2e44a
• https://github.com/gitaroktato/feign/commit/62540165b4efaf6543697ea7e5528989d8810d64

Could you take a brief look and suggest which one aligns better with the existing design? The main problem is that the root cause of the HTTP protocol error is in the thrown exception's stack trace. So it's required for someone who would like to understand what was the issue. If I use the original ErrorDecoder's interface then this information is lost, because it's receiving the response instead of the exception.

[Vaibhav-tech22]

Hey @velo, is this issue closed. If not I would like to give it a try

[velo]

Still needs work.

Probably some tests showing the issue and handling the exception at Client code

[young0264]

@velo
Hi, I'd like to give this issue a try and follow up on the previously suggested approaches.
I'll check the exception handling inside ApacheHttpClient and evaluate how to pass root cause info to ErrorDecoder.
Let me know if there's any preference for the direction.