-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modularize parameterization, joining topologies and creating systems #101
Comments
@ijpulidos we should discuss this more, this is already something we do in |
Yes, there are functions that do this in |
🤔 I'm not sure I fully understand the intent. Ideally I would like us to not be in a situation where we are deciding long term code decisions this side of the year, is this something we can avoid? i.e. is there anything right now that is necessary that is blocking other things? I will focus my efforts towards refactoring the protocols in the new year, which will probably involve dealing with all this with all the stakeholders at once. |
The intention is not having to write code that will be redundant in the future. Especially if we cannot track exactly what would the redundant parts be. My thought was that maybe it is desirable that we can start working on this right now. But of course, I also don't want to put too much effort into this to later find out it wasn't the right approach, so I agree it needs further discussion, but I'm also willing to put some effort and find out if it fits in the future (next year). |
That sounds good, thanks for agreeing to my selfish "can we wait until after the winter holidays" request! |
Basically this issue and the PR that would eventually solve it would be my first proposal on how to solve this from my point of view. Which would be the accepted way or not in the longer term, that's fine, but hopefully it will be minimally functional that will enable having results on protein mutations, does that sound ok? |
I think so, I will lean heavily on "I'm not sure I fully understand" 😅 - but erm as long as we're not blocking you that sounds great! |
Many protocols need to do the same things as parameterizing small molecule components, creating OpenMM topologies and merging them in a hybrid one, and creating OpenMM systems from that. Each of these should probably happen in their own callable and these should be ready to be used by the protocols as needed.
The text was updated successfully, but these errors were encountered: