test+docs(svip): update tests and docs for standalone activated/paused state

Author: BornPsych

evmd/docs/SVIP.md

@@ -148,8 +148,6 @@ Open `/tmp/svip_set_params.json` and replace `<GOV_AUTHORITY>` with the address
       "@type": "/cosmos.svip.v1.MsgUpdateParams",
       "authority": "og10d07y265gmmuvt4z0w9aw880jnsr700jrdya3k",
       "params": {
-        "activated": false,
-        "paused": false,
         "half_life_seconds": "473364000"
       }
     }
@@ -202,12 +200,11 @@ Status should be `PROPOSAL_STATUS_PASSED`.
 evmd q svip params
 ```
 
-> **Heads up:** Don't be alarmed if this shows `params: {}`. Before activation, both `activated` and `paused` are `false`, and `half_life_seconds` is an integer. Proto3 serialization drops fields that equal their default values (`false`, `0`), so the whole thing looks empty even though the values are stored correctly. If you want proof, just move on to step 3. `MsgActivate` will reject with "half_life_seconds must be set before activation" if the value didn't stick.
+> **Heads up:** Don't be alarmed if this shows `params: {}`. `half_life_seconds` is an integer, and proto3 serialization drops fields that equal their default value (`0`), so the whole thing looks empty even though the value is stored correctly. If you want proof, just move on to step 3. `MsgActivate` will reject with "half_life_seconds must be set before activation" if the value didn't stick.
 
 > **Devnet:** Use `--from mykey --home ~/.og-evm-devnet --chain-id 10740 --keyring-backend test --gas 300000 --gas-prices 10000000ogwei` for both submit and vote. Deposit is `10000000ogwei`. Wait ~35 seconds after voting.
 
 **Guardrails:**
-- You can't set `activated` back to `false` once it's been turned on. Activation is permanent.
 - `half_life_seconds` must be at least 1 year.
 - After activation, `half_life_seconds` can't change by more than 50% in a single proposal.
 
@@ -391,14 +388,14 @@ evmd q svip pool-state
 ## Queries
 
 ```bash
-# Module parameters (activated, paused, half_life_seconds)
+# Module parameters (half_life_seconds)
 evmd q svip params
 
 # Pool state (balance, total distributed, current rate, activation time)
 evmd q svip pool-state
 ```
 
-> **About `params: {}`:** The params query uses proto3 serialization, which drops fields that equal their default value (`false` for bools, `0` for integers). Before activation, this means you'll see `params: {}` even when `half_life_seconds` is set. After activation, `activated: true` shows up but `paused` still hides when it's false. Don't worry, the values are stored correctly. Use `q svip pool-state` for the full picture.
+> **About `params: {}`:** The params query uses proto3 serialization, which drops fields that equal their default value (`0` for integers). This means you'll see `params: {}` even when `half_life_seconds` is set to 0. Don't worry, the value is stored correctly. Use `q svip pool-state` for the full picture including activated/paused status.
 
 ---
 

evmd/docs/svip_update_params_proposal.json

@@ -4,8 +4,6 @@
       "@type": "/cosmos.svip.v1.MsgUpdateParams",
       "authority": "<GOV_AUTHORITY>",
       "params": {
-        "activated": false,
-        "paused": false,
         "half_life_seconds": "473364000"
       }
     }

x/svip/keeper/keeper_test.go

@@ -70,15 +70,43 @@ func TestGetSetParams(t *testing.T) {
 
 	// Set custom params and read back
 	custom := types.Params{
-		Activated:       true,
-		Paused:          false,
 		HalfLifeSeconds: 31536000,
 	}
 	require.NoError(t, td.keeper.SetParams(td.ctx, custom))
 	got := td.keeper.GetParams(td.ctx)
 	require.Equal(t, custom, got)
 }
 
+func TestGetSetActivated(t *testing.T) {
+	td := newMockedTestData(t)
+
+	// Default is false
+	require.False(t, td.keeper.GetActivated(td.ctx))
+
+	// Set true and read back
+	td.keeper.SetActivated(td.ctx, true)
+	require.True(t, td.keeper.GetActivated(td.ctx))
+
+	// Set false and read back
+	td.keeper.SetActivated(td.ctx, false)
+	require.False(t, td.keeper.GetActivated(td.ctx))
+}
+
+func TestGetSetPaused(t *testing.T) {
+	td := newMockedTestData(t)
+
+	// Default is false
+	require.False(t, td.keeper.GetPaused(td.ctx))
+
+	// Set true and read back
+	td.keeper.SetPaused(td.ctx, true)
+	require.True(t, td.keeper.GetPaused(td.ctx))
+
+	// Set false and read back
+	td.keeper.SetPaused(td.ctx, false)
+	require.False(t, td.keeper.GetPaused(td.ctx))
+}
+
 func TestGetSetTotalDistributed(t *testing.T) {
 	td := newMockedTestData(t)
 
@@ -144,8 +172,9 @@ func TestBeginBlock_NotActivated(t *testing.T) {
 func TestBeginBlock_Paused(t *testing.T) {
 	td := newMockedTestData(t)
 
-	params := types.Params{Activated: true, Paused: true, HalfLifeSeconds: 31536000}
-	require.NoError(t, td.keeper.SetParams(td.ctx, params))
+	require.NoError(t, td.keeper.SetParams(td.ctx, types.Params{HalfLifeSeconds: 31536000}))
+	td.keeper.SetActivated(td.ctx, true)
+	td.keeper.SetPaused(td.ctx, true)
 
 	err := td.keeper.BeginBlock(td.ctx)
 	require.NoError(t, err)
@@ -160,9 +189,9 @@ func TestBeginBlock_Distributes(t *testing.T) {
 	halfLife := int64(31536000)
 	poolBalance := sdkmath.NewInt(1_000_000_000_000)
 
-	// Set params as activated
-	params := types.Params{Activated: true, Paused: false, HalfLifeSeconds: halfLife}
-	require.NoError(t, td.keeper.SetParams(td.ctx, params))
+	// Set params and activate
+	require.NoError(t, td.keeper.SetParams(td.ctx, types.Params{HalfLifeSeconds: halfLife}))
+	td.keeper.SetActivated(td.ctx, true)
 
 	// Set activation state
 	activationTime := time.Date(2025, 1, 1, 0, 0, 0, 0, time.UTC)
@@ -216,8 +245,8 @@ func TestBeginBlock_CapsAtPoolBalance(t *testing.T) {
 	// Remaining pool balance is tiny — smaller than calculated reward
 	tinyBalance := sdkmath.NewInt(1)
 
-	params := types.Params{Activated: true, Paused: false, HalfLifeSeconds: halfLife}
-	require.NoError(t, td.keeper.SetParams(td.ctx, params))
+	require.NoError(t, td.keeper.SetParams(td.ctx, types.Params{HalfLifeSeconds: halfLife}))
+	td.keeper.SetActivated(td.ctx, true)
 
 	activationTime := time.Date(2025, 1, 1, 0, 0, 0, 0, time.UTC)
 	td.keeper.SetActivationTime(td.ctx, activationTime)

x/svip/keeper/msg_server_test.go

@@ -32,72 +32,51 @@ func TestUpdateParams_InvalidAuthority(t *testing.T) {
 	require.ErrorContains(t, err, "invalid authority")
 }
 
-func TestUpdateParams_CannotDeactivate(t *testing.T) {
-	td := newMockedTestData(t)
-	srv := keeper.NewMsgServerImpl(td.keeper)
-
-	// Set as activated
-	require.NoError(t, td.keeper.SetParams(td.ctx, types.Params{
-		Activated: true, HalfLifeSeconds: 31536000,
-	}))
-
-	_, err := srv.UpdateParams(td.ctx, &types.MsgUpdateParams{
-		Authority: govAuthority(),
-		Params:    types.Params{Activated: false, HalfLifeSeconds: 31536000},
-	})
-	require.ErrorContains(t, err, "cannot deactivate")
-}
-
 func TestUpdateParams_HalfLifeChangeCap(t *testing.T) {
 	td := newMockedTestData(t)
 	srv := keeper.NewMsgServerImpl(td.keeper)
 
-	require.NoError(t, td.keeper.SetParams(td.ctx, types.Params{
-		Activated: true, HalfLifeSeconds: 100_000_000,
-	}))
+	require.NoError(t, td.keeper.SetParams(td.ctx, types.Params{HalfLifeSeconds: 100_000_000}))
+	td.keeper.SetActivated(td.ctx, true)
 
 	// >50% increase (1.6x) should fail
 	_, err := srv.UpdateParams(td.ctx, &types.MsgUpdateParams{
 		Authority: govAuthority(),
-		Params:    types.Params{Activated: true, HalfLifeSeconds: 160_000_000},
+		Params:    types.Params{HalfLifeSeconds: 160_000_000},
 	})
 	require.ErrorIs(t, err, types.ErrHalfLifeChange)
 
 	// >50% decrease (0.4x) should fail
 	_, err = srv.UpdateParams(td.ctx, &types.MsgUpdateParams{
 		Authority: govAuthority(),
-		Params:    types.Params{Activated: true, HalfLifeSeconds: 40_000_000},
+		Params:    types.Params{HalfLifeSeconds: 40_000_000},
 	})
 	require.ErrorIs(t, err, types.ErrHalfLifeChange)
 
 	// Exact 0.5x boundary (ratio == 0.5) should pass
 	_, err = srv.UpdateParams(td.ctx, &types.MsgUpdateParams{
 		Authority: govAuthority(),
-		Params:    types.Params{Activated: true, HalfLifeSeconds: 50_000_000},
+		Params:    types.Params{HalfLifeSeconds: 50_000_000},
 	})
 	require.NoError(t, err)
 
 	// Reset to 100M for next boundary test
-	require.NoError(t, td.keeper.SetParams(td.ctx, types.Params{
-		Activated: true, HalfLifeSeconds: 100_000_000,
-	}))
+	require.NoError(t, td.keeper.SetParams(td.ctx, types.Params{HalfLifeSeconds: 100_000_000}))
 
 	// Exact 1.5x boundary (ratio == 1.5) should pass
 	_, err = srv.UpdateParams(td.ctx, &types.MsgUpdateParams{
 		Authority: govAuthority(),
-		Params:    types.Params{Activated: true, HalfLifeSeconds: 150_000_000},
+		Params:    types.Params{HalfLifeSeconds: 150_000_000},
 	})
 	require.NoError(t, err)
 
 	// Reset to 100M for next test
-	require.NoError(t, td.keeper.SetParams(td.ctx, types.Params{
-		Activated: true, HalfLifeSeconds: 100_000_000,
-	}))
+	require.NoError(t, td.keeper.SetParams(td.ctx, types.Params{HalfLifeSeconds: 100_000_000}))
 
 	// Within 50% (1.3x) should pass
 	_, err = srv.UpdateParams(td.ctx, &types.MsgUpdateParams{
 		Authority: govAuthority(),
-		Params:    types.Params{Activated: true, HalfLifeSeconds: 130_000_000},
+		Params:    types.Params{HalfLifeSeconds: 130_000_000},
 	})
 	require.NoError(t, err)
 }
@@ -108,7 +87,7 @@ func TestUpdateParams_HalfLifeMinimum(t *testing.T) {
 
 	_, err := srv.UpdateParams(td.ctx, &types.MsgUpdateParams{
 		Authority: govAuthority(),
-		Params:    types.Params{Activated: false, HalfLifeSeconds: 1000}, // < 1 year
+		Params:    types.Params{HalfLifeSeconds: 1000}, // < 1 year
 	})
 	require.ErrorContains(t, err, "half_life_seconds must be >= 1 year")
 }
@@ -117,7 +96,7 @@ func TestUpdateParams_HappyPath(t *testing.T) {
 	td := newMockedTestData(t)
 	srv := keeper.NewMsgServerImpl(td.keeper)
 
-	newParams := types.Params{Activated: false, HalfLifeSeconds: 63072000} // 2 years
+	newParams := types.Params{HalfLifeSeconds: 63072000} // 2 years
 	_, err := srv.UpdateParams(td.ctx, &types.MsgUpdateParams{
 		Authority: govAuthority(),
 		Params:    newParams,
@@ -138,9 +117,8 @@ func TestActivate_AlreadyActivated(t *testing.T) {
 	td := newMockedTestData(t)
 	srv := keeper.NewMsgServerImpl(td.keeper)
 
-	require.NoError(t, td.keeper.SetParams(td.ctx, types.Params{
-		Activated: true, HalfLifeSeconds: 31536000,
-	}))
+	require.NoError(t, td.keeper.SetParams(td.ctx, types.Params{HalfLifeSeconds: 31536000}))
+	td.keeper.SetActivated(td.ctx, true)
 
 	_, err := srv.Activate(td.ctx, &types.MsgActivate{Authority: govAuthority()})
 	require.ErrorIs(t, err, types.ErrAlreadyActivated)
@@ -159,9 +137,7 @@ func TestActivate_PoolNotFunded(t *testing.T) {
 	td := newMockedTestData(t)
 	srv := keeper.NewMsgServerImpl(td.keeper)
 
-	require.NoError(t, td.keeper.SetParams(td.ctx, types.Params{
-		Activated: false, HalfLifeSeconds: 31536000,
-	}))
+	require.NoError(t, td.keeper.SetParams(td.ctx, types.Params{HalfLifeSeconds: 31536000}))
 
 	denom := vmtypes.GetEVMCoinDenom()
 	moduleAddr := authtypes.NewModuleAddress(types.ModuleName)
@@ -179,9 +155,7 @@ func TestActivate_HappyPath(t *testing.T) {
 	halfLife := int64(31536000)
 	poolBalance := sdkmath.NewInt(1_000_000_000_000)
 
-	require.NoError(t, td.keeper.SetParams(td.ctx, types.Params{
-		Activated: false, HalfLifeSeconds: halfLife,
-	}))
+	require.NoError(t, td.keeper.SetParams(td.ctx, types.Params{HalfLifeSeconds: halfLife}))
 
 	denom := vmtypes.GetEVMCoinDenom()
 	moduleAddr := authtypes.NewModuleAddress(types.ModuleName)
@@ -194,8 +168,7 @@ func TestActivate_HappyPath(t *testing.T) {
 	_, err := srv.Activate(ctx, &types.MsgActivate{Authority: govAuthority()})
 	require.NoError(t, err)
 
-	params := td.keeper.GetParams(ctx)
-	require.True(t, params.Activated)
+	require.True(t, td.keeper.GetActivated(ctx))
 	require.Equal(t, poolBalance, td.keeper.GetPoolBalanceAtActivation(ctx))
 	require.Equal(t, blockTime, td.keeper.GetActivationTime(ctx).UTC())
 	require.Equal(t, blockTime, td.keeper.GetLastBlockTime(ctx).UTC())
@@ -213,9 +186,8 @@ func TestReactivate_PoolNotFunded(t *testing.T) {
 	td := newMockedTestData(t)
 	srv := keeper.NewMsgServerImpl(td.keeper)
 
-	require.NoError(t, td.keeper.SetParams(td.ctx, types.Params{
-		Activated: true, HalfLifeSeconds: 31536000,
-	}))
+	require.NoError(t, td.keeper.SetParams(td.ctx, types.Params{HalfLifeSeconds: 31536000}))
+	td.keeper.SetActivated(td.ctx, true)
 
 	denom := vmtypes.GetEVMCoinDenom()
 	moduleAddr := authtypes.NewModuleAddress(types.ModuleName)
@@ -230,9 +202,9 @@ func TestReactivate_ClearsPaused(t *testing.T) {
 	td := newMockedTestData(t)
 	srv := keeper.NewMsgServerImpl(td.keeper)
 
-	require.NoError(t, td.keeper.SetParams(td.ctx, types.Params{
-		Activated: true, Paused: true, HalfLifeSeconds: 31536000,
-	}))
+	require.NoError(t, td.keeper.SetParams(td.ctx, types.Params{HalfLifeSeconds: 31536000}))
+	td.keeper.SetActivated(td.ctx, true)
+	td.keeper.SetPaused(td.ctx, true)
 	td.keeper.SetTotalPausedSeconds(td.ctx, 500)
 
 	poolBalance := sdkmath.NewInt(1_000_000_000_000)
@@ -247,8 +219,7 @@ func TestReactivate_ClearsPaused(t *testing.T) {
 	_, err := srv.Reactivate(ctx, &types.MsgReactivate{Authority: govAuthority()})
 	require.NoError(t, err)
 
-	params := td.keeper.GetParams(ctx)
-	require.False(t, params.Paused, "reactivate should clear paused flag")
+	require.False(t, td.keeper.GetPaused(ctx), "reactivate should clear paused flag")
 	require.Equal(t, int64(0), td.keeper.GetTotalPausedSeconds(ctx))
 	require.True(t, td.keeper.GetTotalDistributed(ctx).IsZero())
 }
@@ -257,9 +228,8 @@ func TestReactivate_HappyPath(t *testing.T) {
 	td := newMockedTestData(t)
 	srv := keeper.NewMsgServerImpl(td.keeper)
 
-	require.NoError(t, td.keeper.SetParams(td.ctx, types.Params{
-		Activated: true, HalfLifeSeconds: 31536000,
-	}))
+	require.NoError(t, td.keeper.SetParams(td.ctx, types.Params{HalfLifeSeconds: 31536000}))
+	td.keeper.SetActivated(td.ctx, true)
 	td.keeper.SetTotalDistributed(td.ctx, sdkmath.NewInt(5000))
 
 	newPoolBalance := sdkmath.NewInt(500_000_000_000)
@@ -293,9 +263,9 @@ func TestPause_AccumulatesPausedDuration(t *testing.T) {
 	srv := keeper.NewMsgServerImpl(td.keeper)
 
 	// Start with activated + paused
-	require.NoError(t, td.keeper.SetParams(td.ctx, types.Params{
-		Activated: true, Paused: true, HalfLifeSeconds: 31536000,
-	}))
+	require.NoError(t, td.keeper.SetParams(td.ctx, types.Params{HalfLifeSeconds: 31536000}))
+	td.keeper.SetActivated(td.ctx, true)
+	td.keeper.SetPaused(td.ctx, true)
 
 	pauseStart := time.Date(2025, 1, 1, 0, 0, 0, 0, time.UTC)
 	td.keeper.SetLastBlockTime(td.ctx, pauseStart)
@@ -310,9 +280,8 @@ func TestPause_AccumulatesPausedDuration(t *testing.T) {
 	require.Equal(t, int64(100), td.keeper.GetTotalPausedSeconds(ctx))
 	require.Equal(t, unpauseTime, td.keeper.GetLastBlockTime(ctx).UTC())
 
-	// Verify params updated
-	params := td.keeper.GetParams(ctx)
-	require.False(t, params.Paused)
+	// Verify paused flag cleared
+	require.False(t, td.keeper.GetPaused(ctx))
 }
 
 func TestPause_HappyPath(t *testing.T) {
@@ -325,12 +294,12 @@ func TestPause_HappyPath(t *testing.T) {
 	// Pause
 	_, err := srv.Pause(td.ctx, &types.MsgPause{Authority: govAuthority(), Paused: true})
 	require.NoError(t, err)
-	require.True(t, td.keeper.GetParams(td.ctx).Paused)
+	require.True(t, td.keeper.GetPaused(td.ctx))
 
 	// Unpause
 	_, err = srv.Pause(td.ctx, &types.MsgPause{Authority: govAuthority(), Paused: false})
 	require.NoError(t, err)
-	require.False(t, td.keeper.GetParams(td.ctx).Paused)
+	require.False(t, td.keeper.GetPaused(td.ctx))
 }
 
 func TestFundPool_InvalidDepositor(t *testing.T) {
@@ -392,9 +361,7 @@ func TestBeginBlock_AfterPauseUnpause(t *testing.T) {
 	).Return(nil)
 
 	// 1. Activate at T=0
-	require.NoError(t, td.keeper.SetParams(td.ctx, types.Params{
-		Activated: false, HalfLifeSeconds: halfLife,
-	}))
+	require.NoError(t, td.keeper.SetParams(td.ctx, types.Params{HalfLifeSeconds: halfLife}))
 	activationTime := time.Date(2025, 1, 1, 0, 0, 0, 0, time.UTC)
 	ctx := td.ctx.WithBlockTime(activationTime)
 	_, err := srv.Activate(ctx, &types.MsgActivate{Authority: govAuthority()})

x/svip/types/genesis_test.go

@@ -55,12 +55,23 @@ func (suite *GenesisTestSuite) TestGenesisStateValidate() {
 		{
 			"invalid - activated with half_life=0",
 			types.GenesisState{
-				Params:                  types.Params{Activated: true, HalfLifeSeconds: 0},
+				Params:                  types.Params{HalfLifeSeconds: 0},
+				Activated:               true,
 				TotalDistributed:        sdkmath.ZeroInt(),
 				PoolBalanceAtActivation: sdkmath.ZeroInt(),
 			},
 			true,
 		},
+		{
+			"valid - activated with half_life set",
+			types.GenesisState{
+				Params:                  types.Params{HalfLifeSeconds: 31536000},
+				Activated:               true,
+				TotalDistributed:        sdkmath.ZeroInt(),
+				PoolBalanceAtActivation: sdkmath.ZeroInt(),
+			},
+			false,
+		},
 	}
 
 	for _, tc := range testCases {