Remove extra class retain.

Author: zxystd

IntelBluetoothFirmware/BtIntel.cpp

@@ -27,19 +27,15 @@ initWithDevice(IOService *client, IOUSBHostDevice *dev)
 
     m_pUSBDeviceController = new USBDeviceController();
     if (!m_pUSBDeviceController->init(client, dev)) {
-        OSSafeReleaseNULL(m_pUSBDeviceController);
         return false;
     }
     if (!m_pUSBDeviceController->initConfiguration()) {
-         OSSafeReleaseNULL(m_pUSBDeviceController);
         return false;
     }
     if (!m_pUSBDeviceController->findInterface()) {
-         OSSafeReleaseNULL(m_pUSBDeviceController);
         return false;
     }
     if (!m_pUSBDeviceController->findPipes()) {
-         OSSafeReleaseNULL(m_pUSBDeviceController);
         return false;
     }
     return true;

IntelBluetoothFirmware/IntelBluetoothFirmware.cpp

@@ -66,7 +66,6 @@ bool IntelBluetoothFirmware::start(IOService *provider)
         return false;
     }
 
-    m_pDevice->retain();
     if (!m_pDevice->open(this)) {
         XYLog("start fail, can not open device\n");
         cleanUp();
@@ -118,7 +117,7 @@ void IntelBluetoothFirmware::cleanUp()
         if (m_pDevice->isOpen(this)) {
             m_pDevice->close(this);
         }
-        OSSafeReleaseNULL(m_pDevice);
+        m_pDevice = NULL;
     }
 }
 

IntelBluetoothFirmware/USBDeviceController.cpp

@@ -35,9 +35,7 @@ init(IOService *client, IOUSBHostDevice *dev)
 
     mReadBuffer->prepare(kIODirectionIn);
     m_pDevice = dev;
-    m_pDevice->retain();
     m_pClient = client;
-    m_pClient->retain();
     return true;
 }
 
@@ -63,7 +61,6 @@ findInterface()
     if (m_pInterface == NULL) {
         return false;
     }
-    m_pInterface->retain();
     if (!m_pInterface->open(m_pClient)) {
         XYLog("can not open interface\n");
         return false;
@@ -96,13 +93,13 @@ free()
         _hciLock = NULL;
     }
     if (m_pInterface) {
-        if (m_pInterface->isOpen(m_pClient)) {
+        if (m_pClient && m_pInterface->isOpen(m_pClient)) {
             m_pInterface->close(m_pClient);
+            m_pClient = NULL;
         }
-        OSSafeReleaseNULL(m_pInterface);
+        m_pInterface = NULL;
     }
-    OSSafeReleaseNULL(m_pDevice);
-    OSSafeReleaseNULL(m_pClient);
+    m_pDevice = NULL;
     super::free();
 }