Skip to content

Commit 441c8b3

Browse files
committed
Do not generate resources in source tree
Move generated config.h and resources.inc.h to build directory.
1 parent a124567 commit 441c8b3

File tree

4 files changed

+11
-13
lines changed

4 files changed

+11
-13
lines changed

.gitignore

-6
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,4 @@
1-
# generated config file
2-
include/libfreenect2/config.h
3-
4-
# generated resource file
5-
src/resources.inc.h
61
build
7-
lib
82

93
# Dependency folders
104
depends/*/

CMakeLists.txt

+6-3
Original file line numberDiff line numberDiff line change
@@ -57,14 +57,16 @@ FIND_PACKAGE(TurboJPEG REQUIRED) #does not provide a package-config file
5757
# Add includes
5858
INCLUDE_DIRECTORIES(
5959
"${MY_DIR}/include"
60+
${PROJECT_BINARY_DIR} # for generated headers
6061
${LIBFREENECT2_THREADING_INCLUDE_DIR}
6162
${LibUSB_INCLUDE_DIRS}
6263
${TurboJPEG_INCLUDE_DIRS}
6364
)
6465

6566
LINK_DIRECTORIES(${LibUSB_LIBRARY_DIRS})
6667

67-
SET(RESOURCES_INC_FILE "${MY_DIR}/src/resources.inc.h")
68+
SET(RESOURCES_INC_FILE "${PROJECT_BINARY_DIR}/resources.inc.h")
69+
SET(CONFIG_H_FILE "${PROJECT_BINARY_DIR}/libfreenect2/config.h")
6870

6971
SET(SOURCES
7072
include/libfreenect2/protocol/command.h
@@ -84,7 +86,6 @@ SET(SOURCES
8486
include/libfreenect2/double_buffer.h
8587
include/libfreenect2/frame_listener.hpp
8688
include/libfreenect2/frame_listener_impl.h
87-
include/libfreenect2/config.h
8889
include/libfreenect2/libfreenect2.hpp
8990
include/libfreenect2/packet_pipeline.h
9091
include/libfreenect2/packet_processor.h
@@ -114,6 +115,7 @@ SET(SOURCES
114115

115116
${LIBFREENECT2_THREADING_SOURCE}
116117
${RESOURCES_INC_FILE}
118+
${CONFIG_H_FILE}
117119
)
118120

119121
SET(LIBRARIES
@@ -202,7 +204,7 @@ IF(DEFINED CMAKE_INSTALL_RPATH)
202204
MESSAGE(STATUS "RPATH set to ${CMAKE_INSTALL_RPATH}")
203205
ENDIF()
204206

205-
CONFIGURE_FILE("${MY_DIR}/include/libfreenect2/config.h.in" "${MY_DIR}/include/libfreenect2/config.h" @ONLY)
207+
CONFIGURE_FILE("${MY_DIR}/include/libfreenect2/config.h.in" "${CONFIG_H_FILE}" @ONLY)
206208
GENERATE_RESOURCES(${RESOURCES_INC_FILE} ${MY_DIR} ${RESOURCES})
207209

208210
ADD_DEFINITIONS(-DRESOURCES_INC)
@@ -219,6 +221,7 @@ CONFIGURE_FILE(freenect2.pc.in "${PROJECT_BINARY_DIR}/freenect2.pc" @ONLY)
219221

220222
INSTALL(TARGETS freenect2 DESTINATION lib)
221223
INSTALL(DIRECTORY "${MY_DIR}/include/" DESTINATION include PATTERN "*.in" EXCLUDE)
224+
INSTALL(FILES "${CONFIG_H_FILE}" DESTINATION include/${PROJECT_NAME})
222225
IF(LIBFREENECT2_THREADING_TINYTHREAD)
223226
INSTALL(FILES "${MY_DIR}/src/tinythread/tinythread.h" DESTINATION include/${PROJECT_NAME}/tinythread/)
224227
ENDIF(LIBFREENECT2_THREADING_TINYTHREAD)

src/resource.cpp

+2-1
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,8 @@ struct ResourceDescriptor
4545
#ifdef RESOURCES_INC
4646
#include "resources.inc.h"
4747
#else
48-
ResourceDescriptor resource_descriptors[] = {};
48+
static ResourceDescriptor resource_descriptors[] = {};
49+
static int resource_descriptors_length = 0;
4950
#endif
5051

5152
/**

tools/generate_resources.cpp

+3-3
Original file line numberDiff line numberDiff line change
@@ -74,12 +74,12 @@ int main(int argc, char **argv)
7474

7575
for(int i = 2; i < argc; ++i)
7676
{
77-
cout << "unsigned char resource" << (i - 2) << "[] = {" << endl;
77+
cout << "static unsigned char resource" << (i - 2) << "[] = {" << endl;
7878
dumpFile(basefolder + "/" + argv[i]);
7979
cout << "};" << endl;
8080
}
8181

82-
cout << "ResourceDescriptor resource_descriptors[] = {" << endl;
82+
cout << "static ResourceDescriptor resource_descriptors[] = {" << endl;
8383

8484
for(int i = 2; i < argc; ++i)
8585
{
@@ -91,7 +91,7 @@ int main(int argc, char **argv)
9191
}
9292

9393
cout << "};" << endl;
94-
cout << "int resource_descriptors_length = " << (argc - 2) << ";" << endl;
94+
cout << "static int resource_descriptors_length = " << (argc - 2) << ";" << endl;
9595

9696
return 0;
9797
}

0 commit comments

Comments
 (0)